Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset viewer shows no space between !#endif and a comment line in uBlock's list #1603

Closed
6 of 8 tasks
uBlock-user opened this issue May 25, 2021 · 0 comments
Closed
6 of 8 tasks
Labels
bug Something isn't working fixed issue has been addressed

Comments

@uBlock-user
Copy link
Contributor

uBlock-user commented May 25, 2021

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported
  • The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
    • If the issue is still present after wholly disabling uBO in the browser, then the issue is unrelated to uBO
  • I tried to reproduce the issue when...
    • uBO is the only extension
    • uBO with default lists/settings
    • using a new, unmodified browser profile
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Asset viewer shows no space between !#endif and a comment line in uBlock Privacy list, even though the space is present in the privacy list and shown everywhere else.

A specific URL where the issue occurs

moz-extension://[UUID]/asset-viewer.html?url=ublock-privacy

Steps to Reproduce

  • Click on the popup menu and click on dashboard, followed by clicking on the filter lists pane

  • Near the uBlock filters – Privacy listing, click on the eye icon, tooltipped View content

  • Search for no-floc in the search widget and hit Enter

  • Observe that there's no space shown between !#endif and ! https://github.com/AdguardTeam/AdguardFilters/issues/80625

Expected behavior:

A space be displayed between !#endif and ! https://github.com/AdguardTeam/AdguardFilters/issues/80625

Actual behavior:

There's no space shown between !#endif and ! https://github.com/AdguardTeam/AdguardFilters/issues/80625

Your environment

  • uBlock Origin version: uBO dev build
  • Browser Name and version: Firefox Nightly/Stable
  • Operating System and version: Win X
@uBlock-user uBlock-user added the bug Something isn't working label May 25, 2021
gorhill added a commit to gorhill/uBlock that referenced this issue May 26, 2021
@uBlock-user uBlock-user added the fixed issue has been addressed label May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

1 participant