Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use +js name for logging #209

Closed
3 of 8 tasks
joey04 opened this issue Sep 6, 2018 · 0 comments
Closed
3 of 8 tasks

Use +js name for logging #209

joey04 opened this issue Sep 6, 2018 · 0 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@joey04
Copy link

joey04 commented Sep 6, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

This is a suggestion to change script:inject logging to the new +js name, because it's shorter and thus allows the inject parameters to be more visible. Plus uAssets recently converted to the new name.

I've been logging with +js in my fork since March. The only extra item needed is a small reverse-lookup converter, like this.


I also suggest changing the logged type to script instead of dom. It has the advantage of better text filtering, e.g. using script| to see all script activity or !|dom to hide all cosmetics while still seeing injects.

(I also changed the ^script:has-text log type to inline-script for the same reasons.)

@uBlock-user uBlock-user added the enhancement New feature or request label Sep 6, 2018
@uBlock-user uBlock-user added the fixed issue has been addressed label Sep 7, 2018
hawkeye116477 added a commit to hawkeye116477/uBlock-for-firefox-legacy that referenced this issue Jun 28, 2020
fix uBlockOrigin/uBlock-issues#209 

Co-authored-by:  gorhill <rhill@raymondhill.net>
hawkeye116477 added a commit to hawkeye116477/uBlock-for-firefox-legacy that referenced this issue Jun 28, 2020
fix uBlockOrigin/uBlock-issues#209 

Co-authored-by:  gorhill <585534+gorhill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

2 participants