Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the logger window does not open full screen #663

Closed
8 tasks
Hifexar opened this issue Jul 8, 2019 · 15 comments
Closed
8 tasks

the logger window does not open full screen #663

Hifexar opened this issue Jul 8, 2019 · 15 comments
Labels
external issue involving an external factor Firefox specific to Firefox fixed issue has been addressed

Comments

@Hifexar
Copy link

Hifexar commented Jul 8, 2019

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

The logger window does not open full screen.

You can see it here:
https://gyazo.com/0967199bdb5511e6e29a14c0d77dfb91

Steps to Reproduce:

  1. Open the logger.

Is it possible as an option to leave the ability to work the logger to work in the tab? The pop-up window is very inconvenient.

Firefox 67.0.4 x64
Windows 7 SP1 x64
uBlock Origin v1.20.3b8

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. Open the logger.

Expected behavior:

[What you expected to happen]

Actual behavior:

[What actually happened]

Your environment

Firefox 67.0.4 x64
Windows 7 SP1 x64
uBlock Origin v1.20.3b8

  • uBlock Origin version:
  • Browser Name and version:
  • Operating System and version:
@uBlock-user
Copy link
Contributor

Is it possible as an option to leave the ability to work the logger to work in the tab? The pop-up window is very inconvenient.

https://github.com/uBlockOrigin/uBlock-issues/wiki/The-logger#tip

@uBlock-user uBlock-user added the something to address something to address label Jul 8, 2019
@uBlock-user
Copy link
Contributor

The logger window does not open full screen.

Can you not maximise manually ?

@Hifexar
Copy link
Author

Hifexar commented Jul 8, 2019

No, I can't maximize it manually. It's not working. Maximization is not active. This can be seen in the screenshot. This is a separate window, with which nothing can be done except as collapse. Or resize the width and height manually. This is not a tab but a window without controls.

@Hifexar
Copy link
Author

Hifexar commented Jul 8, 2019

@uBlock-user
Copy link
Contributor

uBlock-user commented Jul 8, 2019

What should I see at this link?

Hold the Shift key while clicking the "Open the logger" icon to toggle between opening the logger in a separate window or in a separate tab. uBO will remember that setting when you open the logger next time, without having to hold the Shift key.

No, I can't maximize it manually. It's not working. Maximization is not active. This can be seen in the screenshot. This is a separate window, with which nothing can be done except as collapse. Or resize the width and height manually. This is not a tab but a window without controls.

Not sure why it's like that for you., on my device, I can minimise/maximise and change the size of it as I want. I can't maximise either on Firefox, I can still change the size though. I remember this being a firefox issue specifically for some user who reported on TOR browser.

@Hifexar
Copy link
Author

Hifexar commented Jul 8, 2019

"Hold the Shift key while clicking the "Open the logger""

Ооо! Thanks!

@Hifexar
Copy link
Author

Hifexar commented Jul 8, 2019

"Not sure why it's like that for you., on my device, I can minimise/maximise and change the size of it as I want."

Homes in Windows 10, too, like works. But it is necessary to specify this. And in office in Windows 7 at me doesn't work.

@uBlock-user uBlock-user added the Firefox specific to Firefox label Jul 8, 2019
@uBlock-user
Copy link
Contributor

I edited my last reply, I can't maximise it either on Firefox, I can still re-size it though.

@Hifexar
Copy link
Author

Hifexar commented Jul 8, 2019

OK, well there is a workaround when using shift. That's enough for now.

@uBlock-user
Copy link
Contributor

uBlock-user commented Jul 8, 2019

You only use Shift once and the value is saved and set. Regarding the maximising window, that's a Firefox behavior unfortunately.

@uBlock-user uBlock-user added external issue involving an external factor and removed something to address something to address labels Jul 8, 2019
@gorhill
Copy link
Member

gorhill commented Jul 8, 2019

I could add an advanced setting to allow the popup window to be just a normal window instead a popup panel.

@gorhill gorhill reopened this Jul 8, 2019
@uBlock-user uBlock-user added the enhancement New feature or request label Jul 8, 2019
@Hifexar
Copy link
Author

Hifexar commented Jul 8, 2019

I could add an advanced setting to allow the popup window to be just a normal window instead a popup panel.

That would be nice.

@shailshouryya
Copy link

Also using Firefox (Mac OS X 10.14.5), can confirm that the uBlock Origin opens in a new window without any ability to close or minimize it. Tried force quitting Firefox, opening it up again, and the logger window also opened up as Firefox restored my previous session. It would be nice if there was a feature to close/minimize the popup window so we could close it after we finish working with it, as of now I need to resize it and move it away to get it out of the way of what I'm working on.

Application info:
Name Firefox
Version 68.0.1
Build ID 20190717172542

uBlock Origin v1.21.2

@gwarser
Copy link

gwarser commented Aug 6, 2019

uBlock Origin opens in a new window without any ability to close or minimize it.

This is Firefox bug https://bugzilla.mozilla.org/show_bug.cgi?id=1516819

gorhill added a commit to gorhill/uBlock that referenced this issue Sep 6, 2019
Related issue:
- uBlockOrigin/uBlock-issues#663

The advanced setting `loggerPopupType` has been added, to
control the type of window to be used when the logger is
launched as a separate window.

The default value is `popup`, it can be changed to any of
the values documented at:

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/windows/CreateType
@uBlock-user
Copy link
Contributor

Set loggerPopupType to normal to enable maximisation. Setting available in the dev build as an advance setting.

@uBlock-user uBlock-user added fixed issue has been addressed and removed enhancement New feature or request labels Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external issue involving an external factor Firefox specific to Firefox fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

5 participants