on_open error handling

[ddosoff]

How I can detect connect errors?

[ghost]

Read the docs and don't open bug reports to get free support

[ddosoff]

Hello Alex. If you want to monetize support, make clear the price for individuals like me. I'm not bitfinex. It seems error handling absent for client sockets. Why not to pass error from poll?

…

On Mon, Dec 24, 2018 at 9:16 AM Alex Hultman ***@***.***> wrote: Read the docs and don't open bug reports to get free support — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AATevLq36rJfSV1AEECtydU3R9UKOqkkks5u8FUAgaJpZM4ZgGJC> .

[ghost]

Unless something is wrong you should get on close event before on open. That could be improved but works as is

[ddosoff]

I'm going to implement async https://tarantool.org/ client using uWebSockets. Will be great to print connection error, if server port is not open or some misconfiguration in the server url. I tried connecting to the closed port. I got on_open, then on_close. When I uncomented https://github.com/uNetworking/uSockets/blob/master/src/loop.c#L132 I see socket error 24. Why not to pass it to on_open?

…

On Tue, Dec 25, 2018 at 7:02 PM Alex Hultman ***@***.***> wrote: Unless something is wrong you should get on close event before on open. That could be improved but works as is — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AATevK2Jk1b2S3VPKosKhnCcJe5WdedTks5u8jAJgaJpZM4ZgGJC> .

[ghost]

That's probably a bug, should be fixed. I don't know exactly how yet

[ddosoff]

You can get error from async socket like this: int valopt; socklen_t lon; getsockopt(us_poll_fd(p), SOL_SOCKET, SO_ERROR, (void*)(&valopt), &lon); if (valopt) { fprintf(stderr, "Error in connection() %d - %s\n", valopt, strerror(valopt)); exit(0); }

…

On Tue, Dec 25, 2018 at 9:26 PM Alex Hultman ***@***.***> wrote: That's probably a bug, should be fixed. I don't know exactly how yet — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AATevMZFUpAvbP223qjOpia1B3MNuSBVks5u8lGygaJpZM4ZgGJC> .