Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency org.owasp.antisamy:antisamy to v1.7.5 [security] #380

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 9, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.owasp.antisamy:antisamy 1.7.2 -> 1.7.5 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2023-43643

Impact

There is a potential for a mutation XSS (mXSS) vulnerability in AntiSamy caused by flawed parsing of the HTML being sanitized. To be subject to this vulnerability the preserveComments directive must be enabled in your policy file and also allow for certain tags at the same time. As a result, certain crafty inputs can result in elements in comment tags being interpreted as executable when using AntiSamy's sanitized output.

Patches

Patched in AntiSamy 1.7.4 and later. See important remediation details in the reference given below.

Workarounds

If you cannot upgrade to a fixed version of the library, the following mitigation can be applied until you can upgrade: Manually edit your AntiSamy policy file (e.g., antisamy.xml) by deleting the preserveComments directive or setting its value to false, if present. Also it would be useful to make AntiSamy remove the noscript tag by adding this in your tag definitions under the <tagrules> node (or deleting it entirely if present):

<tag name="noscript" action="remove"/>

As the previously mentioned policy settings are preconditions for the mXSS attack to work, changing them as recommended should be sufficient to protect you against this vulnerability when using a vulnerable version of this library. However, the existing bug would still be present in AntiSamy or its parser dependency (neko-htmlunit). The safety of this workaround relies on configurations that may change in the future and don't address the root cause of the vulnerability. As such, it is strongly recommended to upgrade to a fixed version of AntiSamy.

For more information

If you have any questions or comments about this advisory:

Email one of the project co-leaders, listed on the OWASP AntiSamy project page, under "Leaders".

CVE-2024-23635

Impact

There is a potential for a mutation XSS (mXSS) vulnerability in AntiSamy caused by flawed parsing of the HTML being sanitized. To be subject to this vulnerability the preserveComments directive must be enabled in your policy file. As a result, certain crafty inputs can result in elements in comment tags being interpreted as executable when using AntiSamy's sanitized output.

Patches

Patched in AntiSamy 1.7.5 and later. This is due to parsing behavior in the neko-htmlunit dependency, just by updating to a newer version the issue was solved. See important remediation details in the reference given below.

Workarounds

If you cannot upgrade to a fixed version of the library, the following mitigation can be applied until you can upgrade: Manually edit your AntiSamy policy file (e.g., antisamy.xml) by deleting the preserveComments directive or setting its value to false, if present.

As the previously mentioned policy settings are preconditions for the mXSS attack to work, changing them as recommended should be sufficient to protect you against this vulnerability when using a vulnerable version of this library. However, the existing bug would still be present in the parser dependency (neko-htmlunit) and therefore in AntiSamy. The safety of this workaround relies on configurations that may change in the future and don't address the root cause of the vulnerability. As such, it is strongly recommended to upgrade to a fixed version of AntiSamy.

For more information

If you have any questions or comments about this advisory:

Email one of the project co-leaders, listed on the OWASP AntiSamy project page, under "Leaders".


Release Notes

nahsra/antisamy (org.owasp.antisamy:antisamy)

v1.7.5: Release version 1.7.5

Compare Source

This release addresses the vulnerability documented in GHSA-2mrq-w8pv-5pvq. AntiSamy versions prior to v1.7.5 are subject to mutation XSS (mXSS) vulnerability when preserving comments. - https://www.cvedetails.com/cve/CVE-2024-23635.

In addition, a number of libraries and plugins were upgraded.

Note: The upgrade in the HTML parser may alter outputs compared to 1.7.4 and before. This may impact regression tests that involve AntiSamy if they are too strict when comparing a resulting output with the expected one.

v1.7.4: Release version 1.7.4

Compare Source

This release addresses the vulnerability documented in CVE-2023-43643. AntiSamy versions prior to v1.7.4 are subject to mutation XSS (mXSS) vulnerability when preserving comments. - https://www.cvedetails.com/cve/CVE-2023-43643.

In addition, a number of libraries and plugins were upgraded, including one with a known vulnerability. Specifically, AntiSamy 1.7.4 upgraded to batik-css v1.17 because batik-css:1.16 is subject to https://www.cvedetails.com/cve/CVE-2022-44729.

Note: The upgrade in the HTML parser may alter outputs compared to 1.7.3 and before. This may impact in regression tests that involve AntiSamy if they are too strict when comparing a resulting output with the expected one.

v1.7.3: Release version 1.7.3

Compare Source

This release simply upgrades a number of dependencies, including one with a known CVE. Versions of org.htmlunit:neko-htmlunit prior to 3.0.0 used by AntiSamy 1.7.2 is subject to CVE-2023-26119.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/maven-org.owasp.antisamy-antisamy-vulnerability branch 2 times, most recently from cb802ca to 3790fa6 Compare October 28, 2023 13:01
@renovate renovate bot force-pushed the renovate/maven-org.owasp.antisamy-antisamy-vulnerability branch from 3790fa6 to 958f087 Compare November 11, 2023 13:00
@renovate renovate bot force-pushed the renovate/maven-org.owasp.antisamy-antisamy-vulnerability branch from 958f087 to 83fb733 Compare February 2, 2024 22:18
@renovate renovate bot changed the title fix(deps): update dependency org.owasp.antisamy:antisamy to v1.7.4 [security] fix(deps): update dependency org.owasp.antisamy:antisamy to v1.7.5 [security] Feb 2, 2024
@renovate renovate bot force-pushed the renovate/maven-org.owasp.antisamy-antisamy-vulnerability branch from 83fb733 to c74f116 Compare August 29, 2024 21:03
@ChristianMurphy ChristianMurphy merged commit bb1d2c1 into master Aug 29, 2024
8 checks passed
@ChristianMurphy ChristianMurphy deleted the renovate/maven-org.owasp.antisamy-antisamy-vulnerability branch August 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant