fix: force unix path separator and EoL #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjagg
requested review from
jonathanmtran,
asgrant,
cousquer,
jgribonvald,
ChristianMurphy,
loulou2u,
amgoodfellow and
cbeach47
jonathanmtran
approved these changes
Dec 17, 2021
|
Thanks @jonathanmtran ! |
jgribonvald
reviewed
Dec 18, 2021
There was a problem hiding this comment.
LGTM.
Maybe some pointers on other way to do to contruct URL:https://www.google.com/url?sa=t&source=web&rct=j&url=https://www.baeldung.com/java-url&ved=2ahUKEwi5mKm13-z0AhWV3oUKHUQcA-EQFnoECBEQAQ&usg=AOvVaw2oQkcV5XZMzPydq7kNZW4b
And I know that the httpClient have some system ( with Path or URI/ URL) appender ( if no other lib have it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI checks were failing on Windows due to differing EoL and path separator characters. Code has been updated to force the more web friendly *nix values.
Resolves #185