Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the current resource-server-webapp with a version based on Spring Boot and add support for webjars #83

Conversation

drewwills
Copy link
Contributor

fixes #82

With this change, you'll be able to add webjars to uPortal-start with a dependency like this one...

runtime 'org.webjars.npm:uportal__content-carousel:1.6.0@jar'

and publish web components-based content with HTML like this example...

  <script src="https://unpkg.com/vue@2.5.16"></script>
  <script type="text/javascript" src="/ResourceServingWebapp/webjars/uportal__content-carousel/1.6.0/dist/content-carousel.js"></script>
  <content-carousel
          type="portlet"
          source="/uPortal/api/v4-3/dlm/portletRegistry.json"
          slick-options="{slidesToShow: 6, infinite: true, arrows: true, dots: true}">
  </content-carousel>

@ChristianMurphy ChristianMurphy self-requested a review August 14, 2018 01:27
…m within resource-server-webapp/ since it's a sub-module
@ChristianMurphy
Copy link
Member

Is this something that can be backported to 1.0.x? It seems like a breaking change.

@drewwills
Copy link
Contributor Author

Is this something that can be backported to 1.0.x? It seems like a breaking change.

It's not a "breaking change," in the sense that the new code has all the same behaviors as the old code, and you can use it in place of the old release without any configuration adjustments, etc.

But it is an unusual change to include in a patch release, because...

  • It completely guts & replaces an existing module
  • It includes (significant!) new capabilities

You know what the issue is: uPortal cannot run without a copy of ResourceServingWebapp 1.0.x.

We can either backport these enhancements (merge this PR), or bundle two copies in uPortal-start -- one old, one new.

Let's attempt the latter approach first. (We can hold off on this PR, but we need to merge the other one.)

@drewwills
Copy link
Contributor Author

Didn't this update get merged (and released) ages ago?

@ChristianMurphy
Copy link
Member

It is released on master, it has not been backported to v1 yet.

@bjagg bjagg merged commit efa9174 into uPortal-Project:rel-1-0-patches Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants