-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enabled resourceChain for the webjars handler #85
feat: Enabled resourceChain for the webjars handler #85
Conversation
This enables webjars-locator to function when present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Thanks @jonathanmtran!
This is a desirable feature. Does it work? I had a lot of problems with it in FBMS. I see this warning in the docs...
What does it mean? (I don't follow.) |
So far so good. It could benefit from additional testing I got the change to make from https://stackoverflow.com/questions/44200423/webjars-locator-doesnt-work-with-xml-based-spring-mvc-4-2-x-configuration |
👍 |
@jonathanmtran, @ChristianMurphy, @jgribonvald, @cousquer... Can anyone think of a good reason not to add I'm inclined to do that. |
FYI -- I just tested this change locally... works great! 👍 |
@jonathanmtran et al., I'm going to go ahead and bake the The benefits of having it are pretty clear, and AFAIK there aren't any downsides...
|
Sounds good, merge away |
Sounds good to me also. Great idea @drewwills ! |
…o its capabilities will be present and active by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i'm for the merge too !
Checklist
Description of change
Enabled
resourceChain
for the webjars handler. This enableswebjars-locator
to function when present (added to build.gradle overlays/resource-server/build.gradle)webjar-locator
allows us to drop the version when sourcing dependencies such as web componentshttps://www.webjars.org/documentation#springboot
I got the change to make from https://stackoverflow.com/questions/44200423/webjars-locator-doesnt-work-with-xml-based-spring-mvc-4-2-x-configuration
Example Use Case