Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add html-include-element WebComponent #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgribonvald
Copy link
Contributor

Checklist
Description of change

Import the html-include-element WebComponent that permit to fetch remote HTML and includes it into page.

Details are here: https://www.npmjs.com/package/html-include-element

@jgribonvald
Copy link
Contributor Author

I removed the WIP state as it's in production on our side.

@jonathanmtran
Copy link
Contributor

Is this being used anywhere in base uPortal and/or quickstart?

@jgribonvald
Copy link
Contributor Author

Is this being used anywhere in base uPortal and/or quickstart?

No, but we can add it as example with a static page from github repo/docs... Is there something interesting?

@jonathanmtran
Copy link
Contributor

I do not have any examples off the top of my head, but I think including examples would be helpful 👍

@jgribonvald
Copy link
Contributor Author

I do not have any examples off the top of my head, but I think including examples would be helpful +1

If someone find a good static page to provide an example I would be glad to make a PR.

@ChristianMurphy
Copy link
Member

An interesting idea @jgribonvald 🤔
How do you see this fitting with existing solutions like webproxy portlet and jsp pages?
Would this be preferred over those? Or is there a specific use case this solves that the others don't?

@jgribonvald
Copy link
Contributor Author

An interesting idea @jgribonvald thinking
How do you see this fitting with existing solutions like webproxy portlet and jsp pages?
Would this be preferred over those? Or is there a specific use case this solves that the others don't?

WPP open sockets server to server and can break the portal on heavy load when you have a page to proxy into the portal. It was my case on a public resource shown on guest page, the remote link take several seconds to load all the remote site and so the portal wait to get the rendering on a thread, and so when too much waiting thread was opened it breaks the portal. The thing on some case is that we don't need a so much complicated system, sometimes something only loaded from the user browser is really more efficient than any other way.
So as you understood, in that way it's only the the browser of the user that open the remote link, and so the portal can load without waiting the rendering of the link. It's more a tips for more efficiency to complete possible use case. It won't replace the WPP and the jsp page.

After it's a purpose/tips, I use it in production and it's satisfying me a lot for my use case, it avoids to break the portal and use less server resources ! I can provide you a common use case on my production (for providing the user documentation).

@jgribonvald
Copy link
Contributor Author

Hey folks, do you have a static page that we want to show into uPortal quickstart deployement ?
I would like to purpose an example of this use and I need an URL that point to something that won't be removed.

Thanks

@jonathanmtran
Copy link
Contributor

One idea: Publish a plain HTML version of the Connect section found on https://uportal-project.github.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants