-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add html-include-element WebComponent #511
base: master
Are you sure you want to change the base?
Conversation
I removed the WIP state as it's in production on our side. |
Is this being used anywhere in base uPortal and/or quickstart? |
No, but we can add it as example with a static page from github repo/docs... Is there something interesting? |
I do not have any examples off the top of my head, but I think including examples would be helpful 👍 |
If someone find a good static page to provide an example I would be glad to make a PR. |
An interesting idea @jgribonvald 🤔 |
WPP open sockets server to server and can break the portal on heavy load when you have a page to proxy into the portal. It was my case on a public resource shown on guest page, the remote link take several seconds to load all the remote site and so the portal wait to get the rendering on a thread, and so when too much waiting thread was opened it breaks the portal. The thing on some case is that we don't need a so much complicated system, sometimes something only loaded from the user browser is really more efficient than any other way. After it's a purpose/tips, I use it in production and it's satisfying me a lot for my use case, it avoids to break the portal and use less server resources ! I can provide you a common use case on my production (for providing the user documentation). |
Hey folks, do you have a static page that we want to show into uPortal quickstart deployement ? Thanks |
One idea: Publish a plain HTML version of the Connect section found on https://uportal-project.github.io |
Checklist
Description of change
Import the html-include-element WebComponent that permit to fetch remote HTML and includes it into page.
Details are here: https://www.npmjs.com/package/html-include-element