Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add core js and regenerator runtime polyfills #1366

Merged

Conversation

ChristianMurphy
Copy link
Member

Checklist
Description of change

Adds polyfills to uPortal, so that each component does not need to bundle the polyfills individually.
And avoid issues like uPortal-Project/NotificationPortlet#116

Resolves uPortal-Project/uPortal-web-components#117

@ChristianMurphy ChristianMurphy added the enhancement Improvement label Oct 7, 2018
@ChristianMurphy ChristianMurphy added this to the 5.3.0 milestone Oct 7, 2018
@ChristianMurphy
Copy link
Member Author

/cc @jgribonvald @leighgordy @jonathanmtran @mrbenshef @mrapczynski

@drewwills
Copy link
Contributor

LGTM 👍 I'm going to run this branch locally. If I don't see any issues, I will merge it shortly.

@drewwills
Copy link
Contributor

Just tested this PR locally. Everything seems to work.

@drewwills drewwills merged commit 564f0ab into uPortal-Project:master Oct 8, 2018
@ChristianMurphy ChristianMurphy deleted the feat/add-polyfills branch October 8, 2018 19:44
@apetro apetro removed their request for review October 9, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move polyfills to uPortal?
2 participants