Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure QQ Browser on Android is detected correctly as QQ Browser Mobile #446

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Ensure QQ Browser on Android is detected correctly as QQ Browser Mobile #446

merged 3 commits into from
Jan 28, 2020

Conversation

JakeChampion
Copy link
Contributor

@JakeChampion JakeChampion commented Jan 13, 2020

The current detection is causing issues for https://polyfill.io users who have customers using QQ Browser as it is identifying the browser incorrectly as Chrome Mobile whereas it is actually a fork of Chrome that has a different set of features than Chrome has.

@elsigh
Copy link
Contributor

elsigh commented Jan 20, 2020

@JakeChampion can you address the merge conflict with another push?

@JakeChampion
Copy link
Contributor Author

@elsigh done

@commenthol commenthol merged commit 2713a25 into ua-parser:master Jan 28, 2020
@JakeChampion JakeChampion deleted the patch-1 branch January 28, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants