Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArcGIS/GIS products #468

Merged
merged 1 commit into from
May 15, 2020
Merged

Add ArcGIS/GIS products #468

merged 1 commit into from
May 15, 2020

Conversation

daveol
Copy link
Contributor

@daveol daveol commented Mar 4, 2020

This:

  • Adds ArcGIS Products
  • Fixes some Windows detections
  • Adds JOSM and QGIS
  • Adds FME form Safe

@daveol
Copy link
Contributor Author

daveol commented Mar 4, 2020

Fixes #277

@commenthol
Copy link
Contributor

Hi @daveol.
Thanks for your contribution.
Can you please move the regexes more in direction bottom of the parsers list. They are pretty unique so they will match at the bottom as well.
Reason is performance, every (popular) user agent will need to pass through your regexes. Let's try to save energy.

This commit:
- Adds ArcGIS Products
- Fixes Windows detections
- Adds JOSM and QGIS
- Adds FME form Safe
- Adds Tygron Platform
- Adds Windows powershell
@commenthol commenthol merged commit b8f628a into ua-parser:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants