Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device): ensure chromecast parsing doesn't return null #588

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

lbarthon
Copy link
Contributor

@lbarthon lbarthon commented Jun 3, 2024

This is supported by the JS library, but not by all the others. This sets the model to Chromecast, to prevent any possible error going on, as the model is needed in that regex.

Fixes #587

This is supported by the JS library, but not by all the others. This sets the
model to Chromecast, to prevent any possible error going on, as the model is
needed in that regex.
@lbarthon lbarthon requested a review from migueldemoura June 3, 2024 08:44
@lbarthon lbarthon self-assigned this Jun 3, 2024
@migueldemoura migueldemoura merged commit df56280 into master Jun 3, 2024
3 checks passed
@migueldemoura migueldemoura deleted the lbarthon/chromecast-fix branch June 3, 2024 09:50
@migueldemoura
Copy link
Member

@lbarthon as a follow-up when we have time, if null can't be used here because some libraries like the one #587 don't handle it, should we allow it in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught count error from CodeGenerator because of null value in regexes
2 participants