Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RecipeRadar crawler #598

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat: add RecipeRadar crawler #598

merged 2 commits into from
Sep 17, 2024

Conversation

jayaddison
Copy link
Contributor

Adds both user-agent and device matchers for RecipeRadar's web crawler.

@jayaddison jayaddison mentioned this pull request Aug 16, 2024
Merged
lbarthon
lbarthon reviewed Aug 30, 2024
View reviewed changes
regexes.yaml Outdated Show resolved Hide resolved
@jayaddison
Copy link
Contributor Author

Thanks for the review @lbarthon - it took me a few moments to understand the or empty logic represented by the pipe symbol at the end of group (as used in various other matching regexes), but that makes sense. Do you have any further feedback on this approach?

@jayaddison jayaddison requested a review from lbarthon September 11, 2024 13:49
@jayaddison
Copy link
Contributor Author

(not quite as long as it took me to remember where I recognized the children's book character in your profile picture from, but some time anyway)

@lbarthon lbarthon merged commit c00d168 into ua-parser:master Sep 17, 2024
3 checks passed
@jayaddison
Copy link
Contributor Author

Thank you @lbarthon!

@jayaddison jayaddison deleted the crawlers/add-reciperadar branch September 27, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarthon lbarthon lbarthon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayaddison @lbarthon