re2 not tested on github #191
Milestone
Comments
masklinn
added a commit
to masklinn/uap-python
that referenced
this issue
Feb 27, 2024
This makes the import failure (and possibly test failures) completely invisible in "misconfigured" environments, which is exactly what happened in the github action where I forgot to add the dependency. Fixes ua-parser#191
masklinn
added a commit
to masklinn/uap-python
that referenced
this issue
Feb 27, 2024
This makes the import failure (and possibly test failures) completely invisible in "misconfigured" environments, which is exactly what happened in the github action where I forgot to add the dependency. Fixes ua-parser#191
masklinn
added a commit
to masklinn/uap-python
that referenced
this issue
Feb 27, 2024
This makes the import failure (and possibly test failures) completely invisible in "misconfigured" environments, which is exactly what happened in the github action where I forgot to add the dependency. Fixes ua-parser#191
masklinn
added a commit
to masklinn/uap-python
that referenced
this issue
Feb 27, 2024
This makes the import failure (and possibly test failures) completely invisible in "misconfigured" environments, which is exactly what happened in the github action where I forgot to add the dependency. Fixes ua-parser#191
masklinn
added a commit
to masklinn/uap-python
that referenced
this issue
Feb 27, 2024
This makes the import failure (and possibly test failures) completely invisible in "misconfigured" environments, which is exactly what happened in the github action where I forgot to add the dependency. Fixes ua-parser#191
masklinn
added a commit
to masklinn/uap-python
that referenced
this issue
Feb 27, 2024
This makes the import failure (and possibly test failures) completely invisible in "misconfigured" environments, which is exactly what happened in the github action where I forgot to add the dependency. Fixes ua-parser#191
masklinn
added a commit
that referenced
this issue
Feb 27, 2024
This makes the import failure (and possibly test failures) completely invisible in "misconfigured" environments, which is exactly what happened in the github action where I forgot to add the dependency. Fixes #191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#116 added the re2 parser and re2 as a dependency to tox on platforms where it's available (e719a7e) but the github configuration was not updated to match. As a result, the re2 parser is not tested there.
It would probably be better for the case to be added unconditionally and skipped. Easiest option seems to be adding the parser param if we can resolve the import, and adding a nonsense param with a
marks=pytest.mark.skip(reason=...)otherwise.The text was updated successfully, but these errors were encountered: