Memory optimization #104
Merged
Memory optimization #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@casperisfine thank you for your PR! Seems like |
|
Ah right, I forgot to check for support. |
casperisfine
force-pushed
the
memory-optimization
branch
from
1e03142 to
b050eef
Compare
|
Done. |
`regexes.yaml` contains quite a lot of duplicated strings. By passing `freeze: true` to `YAML.load` we allow the parser to deduplicate them. Additionally, the regexes source and flags are never used, so they can be removed from the long lived hashes. Before: ``` Total allocated: 3.47 MB (28214 objects) Total retained: 1.45 MB (8422 objects) ``` After: ``` Total allocated: 3.71 MB (30218 objects) Total retained: 1.24 MB (4583 objects) ``` It's not a big difference in size, but it cuts down in half the number of objects than need to be marked by the GC.
opti
force-pushed
the
memory-optimization
branch
from
b050eef to
51e0b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regexes.yamlcontains quite a lot of duplicated strings.By passing
freeze: truetoYAML.loadwe allow the parser to deduplicate them.Additionally, the regexes source and flags are never used, so they
can be removed from the long lived hashes.
Before:
After:
It's not a big difference in size, but it cuts down in half the number
of objects than need to be marked by the GC.