Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding testing detection function fix #96

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

wilkb777
Copy link
Member

@wilkb777 wilkb777 commented Jul 9, 2024

Pull request

Fixes #95 . Check issue for full description of what caused the bug and why the testing for this bug is sufficient.


  • Was code modified? Briefly describe. yes, resolves the bug noted above
  • Was documentation modified? Briefly describe. No
  • Is this a bug-fix? Briefly describe. yes, resolves the bug noted above
  • Is this a feature addition? Briefly describe. no
  • Did you modify QuaC-Watch config file? If so, did you modify multiqc template no
    configs/multiqc_config_template.jinja2 and script src/quac_watch/create_mutliqc_configs.py as necessary?
  • Did you perform system-level testing manually, using ----cli_cluster_config and --snakemake_cluster_config
    options, as described in the documentation? Did it pass
    completely? If not why? no, I individually tested the fix for the function identified in Supplying list of files for external FASTQC causes pipeline to fail #95 as that was all that was causing the issue
  • Updated Changelog.md file with change logs in recommended format? yes

Anything else reviewer should know?

@wilkb777 wilkb777 requested a review from ManavalanG July 9, 2024 00:44
@wilkb777 wilkb777 self-assigned this Jul 9, 2024
Copy link
Member

@ManavalanG ManavalanG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@wilkb777 wilkb777 merged commit e4a8cdd into master Jul 9, 2024
2 checks passed
@wilkb777 wilkb777 deleted the testing-detect-fix branch July 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supplying list of files for external FASTQC causes pipeline to fail
2 participants