Skip to content

Commit

Permalink
Annotation Configuration file with versioning details, and leftover a…
Browse files Browse the repository at this point in the history
…nnotation unit refactor (#164)

* Fixed typo

* fixed typo

* Added version fields in configuration file

* Updating Annotations configuration with Versioning Details (#152)

* Added HPO date as version_type

* Added HPO and Ensembl version details

* added alliance genome versioning

* Updated Annotation Configuration with versioning types and corresponding attributes

* Rebased from main branch. Also deleted annotation-logging branch
  • Loading branch information
fatimarabab authored Mar 22, 2024
1 parent 0f27285 commit de8626b
Show file tree
Hide file tree
Showing 5 changed files with 166 additions and 72 deletions.
1 change: 0 additions & 1 deletion backend/src/core/annotation.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import logging
import queue

# from .annotation_logging import annotation_log_label, annotation_unit_string
from .annotation_task import AnnotationTaskFactory
from ..models.analysis import Analysis
from ..repository.annotation_config_collection import AnnotationConfigCollection
Expand Down
19 changes: 0 additions & 19 deletions backend/src/core/annotation_logging.py

This file was deleted.

2 changes: 1 addition & 1 deletion backend/src/repository/annotation_config_collection.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""
Manges the annotation configuration of various genomic units according to the
Manages the annotation configuration of various genomic units according to the
type of Genomic Unit.
"""

Expand Down
2 changes: 1 addition & 1 deletion backend/tests/unit/core/test_annotation_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def test_annotation_task_create_http_task(hgvs_variant_genomic_unit, transcript_


def test_annotate_forge_gene_linkout_dataset(forge_annotation_task_gene):
"""Verifies that the NCBI linkout dataset is structed as expected"""
"""Verifies that the NCBI linkout dataset is structured as expected"""
actual_annotation = forge_annotation_task_gene.annotate()
assert "NCBI_linkout" in actual_annotation
assert actual_annotation['NCBI_linkout'] == 'https://www.ncbi.nlm.nih.gov/gene?Db=gene&Cmd=DetailsSearch&Term=45614'
Expand Down
Loading

0 comments on commit de8626b

Please sign in to comment.