Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the importer to include the new ACMG expected fields #137

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

SeriousHorncat
Copy link
Collaborator

@SeriousHorncat SeriousHorncat commented Sep 13, 2023

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • If it is a core feature, I have added thorough tests.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.

Pull Request Details

Wrike Ticket - Add ACMG fields to Brief

Changes made:

  • Added ACMG fields to be in the brief section and Decision also when creating a case

To Review:

  • Static Analysis by Reviewer

  • The changes made to importing a case is working as intended/rendered correctly.
    To check this run the following commands:

    # From the root of Rosalution
    docker compose down
    docker system prune -a --volumes
    
    docker compose up --build -d
    • Import any valid case
    • Open the case and verify the new fields appear as expected in the brief section
    • Screenshot 2023-09-13 at 8 53 21 AM
  • All Github Actions checks have passed.

@SeriousHorncat SeriousHorncat added the enhancement New feature or request label Sep 13, 2023
@SeriousHorncat SeriousHorncat self-assigned this Sep 13, 2023
@SeriousHorncat SeriousHorncat marked this pull request as ready for review September 13, 2023 14:22
@fatimarabab fatimarabab self-requested a review September 13, 2023 14:47
@fatimarabab
Copy link
Collaborator

Works as expected. Looks good to!
Screenshot 2023-09-13 at 9 52 38 AM

@SeriousHorncat SeriousHorncat merged commit 1d9e35b into main Sep 13, 2023
8 checks passed
@SeriousHorncat SeriousHorncat deleted the acmg-create-fields-exist branch September 13, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants