Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animal model section backend #145

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Animal model section backend #145

merged 8 commits into from
Oct 23, 2023

Conversation

JmScherer
Copy link
Collaborator

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • If it is a core feature, I have added thorough tests.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Will this be part of a product update? If yes, please write one phrase about this update.

Pull Request Details

https://www.wrike.com/open.htm?id=1233370000

Changes made:

  • Added endpoints to attach either a file or link to a section field in an analysis
  • Added endpoints to remove file or link from sections fields in an analysis

To Review:

  • Static Analysis by Reviewer
  • Can you add a file and/or link to the animal model section?
    To check this run the following commands:
    <docker stuff here>
  • All Github Actions checks have passed.

Section File Attach Endpoint Submission

Screenshot 2023-10-23 at 2 22 12 PM

Section File Attach Endpoint Response

Screenshot 2023-10-23 at 2 22 39 PM

Section Link Attach Endpoint Submission

Screenshot 2023-10-23 at 2 22 46 PM

Section Link Attach Endpoint Response

Screenshot 2023-10-23 at 2 24 00 PM

Analysis Animal Model Evidence Fields

Screenshot 2023-10-23 at 2 24 24 PM

Section File Remove Endpoint Submission

Screenshot 2023-10-23 at 2 28 05 PM

Section File Remove Endpoint Response

Screenshot 2023-10-23 at 2 28 31 PM

Analysis Animal Model File Removal Result

Screenshot 2023-10-23 at 2 28 51 PM

Section Link Remove Endpoint Submission

Screenshot 2023-10-23 at 2 30 19 PM

Section Link Remove Endpoint Response

Screenshot 2023-10-23 at 2 30 27 PM

Analysis Animal Model Link Removal Result

Screenshot 2023-10-23 at 2 30 52 PM

@JmScherer JmScherer added the enhancement New feature or request label Oct 23, 2023
@JmScherer JmScherer self-assigned this Oct 23, 2023
Copy link
Collaborator

@SeriousHorncat SeriousHorncat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great. Followed the review as it was documented.

@JmScherer JmScherer merged commit 76465cc into main Oct 23, 2023
8 checks passed
@JmScherer JmScherer deleted the animal-model-section-backend branch October 23, 2023 19:32
Copy link
Collaborator Author

@JmScherer JmScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants