[Backend] Remove and edit post route and methods to update and delete a post from the discussion section

[JmScherer]

Checklist before requesting a review

• I have performed a self-review of my code.
• My code follows the style guidelines enforced by static analysis tools.
• If it is a core feature, I have added thorough tests.
• My changes generate no new warnings.
• New and existing unit tests pass locally with my changes.
• Will this be part of a product update? If yes, please write one phrase about this update.

Pull Request Details

[Backend] Remove and edit post route and methods to update and delete a post from the discussion section

Changes made:

This pull request adds the routes to edit and delete discussion posts in an analysis discussion section.

Get Analysis Discussion Get Route

• @router.get("/{analysis_name}/discussions")
  • analysis_name

Edit Analysis Discussion Post Route

• @router.put("/{analysis_name}/disussions/{discussion_post_id}")
  • analysis_name
  • client_id

Delete Analysis Discussion Post Route

• @router.delete("/{analysis_name}/discussions/{discussion_post_id}")
  • analysis_name
  • client_id

---

To Review:

• Static Analysis by Reviewer
• The changes made to < describe purpose of change > are working as intended/rendered correctly.
  To check this run the following commands:

  # From the root of Rosalution
  docker compose down
  docker system prune -a --volumes
  
  docker compose up --build -d

• Go to https://local.rosalution.cgds/rosalution/
  • Login as developer
  • In the upper left, click the developer text
  • Click the Generate Secret button
  • Make note of the Client Id and Client Secret
• In a new tab, open https://local.rosalution.cgds/rosalution/api/docs
  • Click the green Authorize button at the top of the page
  • Enter your Client Id and Client Secret and click Authorize then click Close
• Open the Get Analysis Discussions route - GET /analysis/{analysis_name}/discussions
  • Click Try it Out and enter CPAM0002 in the analysis_name
  • Click Execute
  • Copy the post_id from the first post made by Developer Person
• Open the Update Analysis Discussion Post - PUT /analysis/{analysis_name}/discussions/{discussion_post_id}
  • Enter CPAM0002 into analysis_name
  • Paste 9027ec8d-6298-4afb-add5-6ef710eb5e98 into discussion_post_id
  • Enter any text you want into the discussion_content
  • Click Execute
  • Does the Developer Person post contain the discussion_content in the content field?
  • Bonus: Go back to Rosalution frontend - did the post content change?
• Open the Delete Analysis Discussion - DELETE /analysis/{analysis_name}/discussions/{discussion_post_id}
  • Enter CPAM0002 in the analysis_name
  • Enter 9027ec8d-6298-4afb-add5-6ef710eb5e98 as the discussion_post_id
  • Click Execute
  • Was the post removed entirely?
  • Bonus: Check Rosalution frontend - was the post content removed?
• All Github Actions checks have passed.

---

Get Analysis Discussion Get Route

Edit Analysis Discussion Post Route

Delete Analysis Discussion Post Route

[SeriousHorncat]

Stepping through the new code works great!!! Just some cleanup and one more unit test to wrap it up. Functionally it works great. Liked how you phrased the test of trying to find a valid post and saying that its valid if the discsusion id authoring by that client exists.

• Getting Discussions
  

• Using PUT to Update Discussion
  

  • Bonus
    

• Deleting a post
  

  • Bonus
    

[SeriousHorncat]

Just a few print statements to get removed and then it is ready to go!