Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document DraftProperties Status Enum in detail #1615

Closed
murny opened this issue Apr 24, 2020 · 1 comment
Closed

Document DraftProperties Status Enum in detail #1615

murny opened this issue Apr 24, 2020 · 1 comment
Assignees
@murny

Comments

@murny
Copy link
Contributor

murny commented Apr 24, 2020

From discovery work found in #1556, one take away is:

The one other suggestion that comes to mind is that we summarize your explanation of the way the status enum interacts with the draft lifecycle and add it as a comment here, so that there's some documentation in the codebase explaining the situation

We should add some code documentation to this status enum in DraftProperties and give a some context around the draft lifecycle for each of its status values
@murny murny self-assigned this Apr 29, 2020
murny added a commit that referenced this issue Apr 30, 2020
@murny
#1615: Document Status enum on DraftItem/DraftThesis models in detail
e463b60
@murny murny mentioned this issue Apr 30, 2020
Merged
murny added a commit that referenced this issue Apr 30, 2020
@murny
Merge pull request #1626 from ualbertalib/add-description-to-status-enum
be07bda 
#1615: Document Status enum on DraftItem/DraftThesis models in detail
@murny
Copy link
Contributor Author

murny commented Apr 30, 2020

Now merged into master. Closing this

@murny murny closed this as completed Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murny murny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@murny