Skip to content

Upgrade Rails to version 7.x #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pgwillia opened this issue Dec 16, 2021 · 6 comments
Closed

Upgrade Rails to version 7.x #2670

pgwillia opened this issue Dec 16, 2021 · 6 comments
Assignees
Milestone

Comments

@pgwillia
Copy link
Member

Here is the release notes and upgrade guide:

@pgwillia
Copy link
Member Author

pgwillia commented Jul 12, 2023

failures_test_can_view_thesis_edit_history

$ bundle exec rails test:system
Running via Spring preloader in process 16350
Run options: --seed 54273

Running:

Capybara starting Puma...

  • Version 6.3.0 , codename: Mugi No Toki Itaru
  • Min threads: 0, max threads: 4
  • Listening on http://127.0.0.1:41269
    ..........Screenshot Image: /home/pjenkins/Code/ualbertalib/jupiter/tmp/screenshots/failures_test_can_view_thesis_edit_history.png
    F

Failure:
ItemEditHistoryTest#test_can_view_thesis_edit_history [/home/pjenkins/Code/ualbertalib/jupiter/test/system/item_edit_history_test.rb:36]:
expected to find css "dt" but there were no matches

rails test test/system/item_edit_history_test.rb:5

F

Failure:
ItemEditHistoryTest#test_can_view_item_edit_history [/home/pjenkins/Code/ualbertalib/jupiter/test/system/item_edit_history_test.rb:79]:
expected to find css "dt" but there were no matches

rails test test/system/item_edit_history_test.rb:51

.............S........................................

Finished in 163.660468s, 0.4033 runs/s, 2.9757 assertions/s.
66 runs, 487 assertions, 2 failures, 0 errors, 1 skips

@pgwillia
Copy link
Member Author

pgwillia commented Jul 12, 2023

Failed tests:

rails test test/controllers/aip/v1/aip_collections_controller_test.rb:42
rails test test/controllers/aip/v1/aip_collections_controller_test.rb:74
rails test test/controllers/aip/v1/aip_collections_controller_test.rb:56
rails test test/controllers/aip/v1/aip_collections_controller_test.rb:24
rails test test/controllers/aip/v1/aip_items_contoller_test.rb:64
rails test test/controllers/aip/v1/aip_items_contoller_test.rb:111
rails test test/controllers/aip/v1/aip_items_contoller_test.rb:257
rails test test/controllers/aip/v1/aip_items_contoller_test.rb:167
rails test test/controllers/aip/v1/aip_items_contoller_test.rb:228
rails test test/controllers/aip/v1/aip_items_contoller_test.rb:143
rails test test/controllers/aip/v1/aip_items_contoller_test.rb:86
rails test test/controllers/aip/v1/aip_items_contoller_test.rb:34
rails test test/controllers/aip/v1/aip_communities_controller_test.rb:39
rails test test/controllers/aip/v1/aip_communities_controller_test.rb:21
rails test test/jobs/digitization/batch_metadata_ingestion_job_test.rb:22
rails test test/controllers/aip/v1/aip_theses_controller_test.rb:105
rails test test/controllers/aip/v1/aip_theses_controller_test.rb:59
rails test test/controllers/aip/v1/aip_theses_controller_test.rb:168
rails test test/controllers/aip/v1/aip_theses_controller_test.rb:197
rails test test/controllers/aip/v1/aip_theses_controller_test.rb:80
rails test test/controllers/aip/v1/aip_theses_controller_test.rb:29

All have triples graphs in common.

ualbertalib/acts_as_rdfable#7 (review)

@murny
Copy link
Contributor

murny commented Aug 30, 2023

Spring is no longer recommended and no longer a default gem in Rails. We can probably remove this, while we work on this upgrade. More info: rails/rails#42997

Update: this is done now.

@murny
Copy link
Contributor

murny commented Sep 26, 2023

Looks like one big change is migrating from image magick to vips as the default. We currently have both at the ready due to using image_processing gem. But it appears imagemagick is the default for this gem. if we want to use Vips in some fashion then this would require some changes (Dockerfile, and installing libvips instead etc)

@pgwillia pgwillia added this to the Goals 2023 milestone Feb 8, 2024
@murny
Copy link
Contributor

murny commented Feb 12, 2024

This is now live in Production

@murny murny closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants