-
Notifications
You must be signed in to change notification settings - Fork 21.9k
Remove spring as a default installation option #42997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faster computers have meant that most apps won't see a big benefit from Spring on small to moderate size apps. Thus the pain of dealing with the occasional spring issue is no longer warranted by default.
ghiculescu
reviewed
Aug 11, 2021
Schwad
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ✅
mattbrictson
added a commit
to carbonfive/raygun-rails
that referenced
this pull request
Aug 18, 2021
Spring seems to be on the way out. The repo doesn't get much attention (very few PRs are accepted and there are many open issues), and new gem versions have been published rarely (3 releases in the last 4 years). And recently spring was just removed from rails itself: in the next version of rails, spring is no longer included in apps generated via `rails new` and there is not even an option for it. The argument is that computers have gotten fast enough that spring is no longer worth the occasional debugging headaches. ("Why isn't this working? Oh I guess I needed to restart spring.") rails/rails#42997 Spring might still have value for very large apps that have long boot times. But since raygun is used for greenfield projects, we should remove it, considering it probably will become more and more of a niche gem going forward.
mattbrictson
added a commit
to carbonfive/raygun-rails
that referenced
this pull request
Aug 25, 2021
Spring seems to be on the way out. The repo doesn't get much attention (very few PRs are accepted and there are many open issues), and new gem versions have been published rarely (3 releases in the last 4 years). And recently spring was just removed from rails itself: in the next version of rails, spring is no longer included in apps generated via `rails new` and there is not even an option for it. The argument is that computers have gotten fast enough that spring is no longer worth the occasional debugging headaches. ("Why isn't this working? Oh I guess I needed to restart spring.") rails/rails#42997 Spring might still have value for very large apps that have long boot times. But since raygun is used for greenfield projects, we should remove it, considering it probably will become more and more of a niche gem going forward.
toshimaru
added a commit
to toshimaru/RailsTwitterClone
that referenced
this pull request
Sep 20, 2021
toshimaru
added a commit
to toshimaru/RailsTwitterClone
that referenced
this pull request
Sep 20, 2021
* Remove spring gem ref. rails/rails#42997 * Delete spring * Remove spring from binstubs
hidakatsuya
added a commit
to thinreports/thinreports-rails-example
that referenced
this pull request
Dec 19, 2021
Remove spring as a default installation option rails/rails#42997
ryogift
pushed a commit
to ryogift/ryogift-api
that referenced
this pull request
Jan 9, 2022
ryogift
pushed a commit
to ryogift/ryogift-api
that referenced
this pull request
Jan 14, 2022
ryogift
pushed a commit
to ryogift/ryogift-api
that referenced
this pull request
Feb 5, 2022
kas-catholic
added a commit
to opensourcecatholic/marriage-booklet
that referenced
this pull request
Mar 26, 2022
Spring is a gem that is supposed to speed up application development with Rails by keeping some things running in the background. In reality, this isn't needed on small to medium scale projects with relatively modern computers, and Spring is infamous for making development harder because of odd behavior (stale caches, etc). Rails recently [removed Spring from its default gems](rails/rails#42997), and we should too.
ryogift
pushed a commit
to ryogift/ryogift-api
that referenced
this pull request
Apr 2, 2022
ghiculescu
added a commit
to ghiculescu/rails
that referenced
this pull request
Dec 5, 2022
In the process of removing spring, rails#42997 added a comment for `config.cache_classes`. Through that PR and subsequent revisions the comment has gotten a bit confusing - it doesn't explain what the `enable_reloading` setting does, just how to revert it if you are using Spring (which isn't included in new apps anymore). So this PR just updates the template with a comment about what the setting does. If someone really wants to use Spring there's other places to learn about how to change this setting, as that's not a default path we're encouraging anymore.
northeastprince
added a commit
to hackclub/hackathons-backend
that referenced
this pull request
Feb 22, 2024
Follows rails/rails#42997
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster computers have meant that most apps won't see a big benefit from Spring on small to moderate size apps. Thus the pain of dealing with the occasional spring issue is no longer warranted by default.