Skip to content

Remove spring as a default installation option #42997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2021
Merged

Conversation

dhh
Copy link
Member

@dhh dhh commented Aug 11, 2021

Faster computers have meant that most apps won't see a big benefit from Spring on small to moderate size apps. Thus the pain of dealing with the occasional spring issue is no longer warranted by default.

Faster computers have meant that most apps won't see a big benefit from Spring on small to moderate size apps. Thus the pain of dealing with the occasional spring issue is no longer warranted by default.
@rails-bot rails-bot bot added the railties label Aug 11, 2021
Copy link
Contributor

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

@dhh dhh merged commit 21c9732 into main Aug 12, 2021
@dhh dhh deleted the spring-no-longer-the-default branch August 12, 2021 10:31
mattbrictson added a commit to carbonfive/raygun-rails that referenced this pull request Aug 18, 2021
Spring seems to be on the way out. The repo doesn't get much attention
(very few PRs are accepted and there are many open issues), and new gem
versions have been published rarely (3 releases in the last 4 years).

And recently spring was just removed from rails itself: in the next
version of rails, spring is no longer included in apps generated via
`rails new` and there is not even an option for it. The argument is that
computers have gotten fast enough that spring is no longer worth the
occasional debugging headaches. ("Why isn't this working? Oh I guess I
needed to restart spring.")

rails/rails#42997

Spring might still have value for very large apps that have long boot
times. But since raygun is used for greenfield projects, we should
remove it, considering it probably will become more and more of a niche
gem going forward.
mattbrictson added a commit to carbonfive/raygun-rails that referenced this pull request Aug 25, 2021
Spring seems to be on the way out. The repo doesn't get much attention
(very few PRs are accepted and there are many open issues), and new gem
versions have been published rarely (3 releases in the last 4 years).

And recently spring was just removed from rails itself: in the next
version of rails, spring is no longer included in apps generated via
`rails new` and there is not even an option for it. The argument is that
computers have gotten fast enough that spring is no longer worth the
occasional debugging headaches. ("Why isn't this working? Oh I guess I
needed to restart spring.")

rails/rails#42997

Spring might still have value for very large apps that have long boot
times. But since raygun is used for greenfield projects, we should
remove it, considering it probably will become more and more of a niche
gem going forward.
toshimaru added a commit to toshimaru/RailsTwitterClone that referenced this pull request Sep 20, 2021
toshimaru added a commit to toshimaru/RailsTwitterClone that referenced this pull request Sep 20, 2021
* Remove spring gem

ref. rails/rails#42997

* Delete spring

* Remove spring from binstubs
hidakatsuya added a commit to thinreports/thinreports-rails-example that referenced this pull request Dec 19, 2021
Remove spring as a default installation option
rails/rails#42997
ryogift pushed a commit to ryogift/ryogift-api that referenced this pull request Jan 9, 2022
ryogift pushed a commit to ryogift/ryogift-api that referenced this pull request Jan 14, 2022
ryogift pushed a commit to ryogift/ryogift-api that referenced this pull request Feb 5, 2022
kas-catholic added a commit to opensourcecatholic/marriage-booklet that referenced this pull request Mar 26, 2022
Spring is a gem that is supposed to speed up application development
with Rails by keeping some things running in the background. In reality,
this isn't needed on small to medium scale projects with relatively
modern computers, and Spring is infamous for making development harder
because of odd behavior (stale caches, etc). Rails recently [removed
Spring from its default
gems](rails/rails#42997), and we should too.
ryogift pushed a commit to ryogift/ryogift-api that referenced this pull request Apr 2, 2022
ghiculescu added a commit to ghiculescu/rails that referenced this pull request Dec 5, 2022
In the process of removing spring, rails#42997 added a comment for `config.cache_classes`. Through that PR and subsequent revisions the comment has gotten a bit confusing - it doesn't explain what the `enable_reloading` setting does, just how to revert it if you are using Spring (which isn't included in new apps anymore).

So this PR just updates the template with a comment about what the setting does. If someone really wants to use Spring there's other places to learn about how to change this setting, as that's not a default path we're encouraging anymore.
northeastprince added a commit to hackclub/hackathons-backend that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants