Remove spring #605
Merged
Remove spring #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring seems to be on the way out. The repo doesn't get much attention
(very few PRs are accepted and there are many open issues), and new gem
versions have been published rarely (3 releases in the last 4 years).
And recently spring was just removed from rails itself: in the next
version of rails, spring is no longer included in apps generated via
`rails new` and there is not even an option for it. The argument is that
computers have gotten fast enough that spring is no longer worth the
occasional debugging headaches. ("Why isn't this working? Oh I guess I
needed to restart spring.")
rails/rails#42997
Spring might still have value for very large apps that have long boot
times. But since raygun is used for greenfield projects, we should
remove it, considering it probably will become more and more of a niche
gem going forward.
mattbrictson
commented
Aug 18, 2021
| load File.expand_path('../spring', __FILE__) | ||
| rescue LoadError => e | ||
| raise unless e.message.include?('spring') | ||
| # frozen_string_literal: true |
There was a problem hiding this comment.
I regenerated this binstub using bundle binstub rspec-core --force to get the non-springified version.
| @@ -24,8 +24,7 @@ FileUtils.chdir APP_ROOT do | |||
| FileUtils.cp ".env.sample", ".env" unless File.exist?(".env") | |||
|
|
|||
| puts "\n== Preparing database ==" | |||
| system! "bin/rails db:prepare" | |||
| system! "bin/rails db:sample_data" | |||
| system! "bin/rails db:prepare db:sample_data" | |||
There was a problem hiding this comment.
Micro-optimization: make these two tasks a single bin/rails call to save on boot time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Spring seems to be on the way out. The repo doesn't get much attention (very few PRs are accepted and there are many open issues), and new gem versions have been published rarely (3 releases in the last 4 years).
And recently spring was just removed from rails itself: in the next version of rails, spring is no longer included in apps generated via
rails newand there is not even an option for it. The argument is that computers have gotten fast enough that spring is no longer worth the occasional debugging headaches. ("Why isn't this working? Oh I guess I needed to restart spring.")rails/rails#42997
Solution
Spring might still have value for very large apps that have long boot times. But since raygun is used for greenfield projects, we should remove it, considering it probably will become more and more of a niche gem going forward.