Remove spring gem to fix gem-related issues
#634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring does not support Rails 7.1 and Ruby 3.3, which are both used in this project.
If you attempt to run a fresh installation of this repo, the tests won't pass because of the importations: - As the arctic_admin gem is not initially on the gemfile, it will cause the system specs to fail. - We also need to have the `active_admin.js` in order to pass the specs (and ensure functionality). Worth mentioning that `arctic_admin/base` already adds `mixins` and `fontawesome`, so there might be no need to add them manually.
rspec-rails gem should be in dev and test environment
Fix `rspec-rails` gem issues (rootstrap#626)
rodrieiz
approved these changes
Feb 22, 2024
jpascual1994
approved these changes
Feb 22, 2024
enzofab91
approved these changes
Feb 22, 2024
santib
approved these changes
Feb 22, 2024
|
I was checking and seems that since rails/rails#42997 the new default is not installing Spring. So this PR sounds good to me. Thanks @bigchickenwings 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @santib, I've created this PR for maintainers (and possibly users) to discuss about what to do with
springgem.Description:
Currently, cloning this repository, running the setup command, and then running the specs don't work.
rails db:prepare and related commands issues (Caused by spring):
They are not working in MacOS M1, and are throwing the following error:
This is a recurring issue, as demonstrated here.
While we can always just disable fork safety, this would go against best practices, and instead we should remove the spring gem or at least disable them for MacOS M1 environments. Let me know the preferred approach.
Also, as Spring does not offer support for Ruby 3.3 and Rails 7.1, we should not use it until further updates. As this doesn't really change the functionality of the app, I believe we're good to just remove it for now.
Notes: