add migration to fix concatenated subjects (part 2) DONT MERGE YET #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwillia
requested review from
ConnorSheremeta,
lagoan,
mbarnett and
murny
as code owners
murny
reviewed
May 1, 2020
pgwillia
force-pushed
the
1449_subjects_edit_success
branch
from
5286009 to
8a449af
Compare
pgwillia
force-pushed
the
1449_subjects_edit_success
branch
from
8a449af to
98a0887
Compare
pgwillia
force-pushed
the
1449_subjects_edit_success
branch
from
98a0887 to
62f02d4
Compare
pgwillia
force-pushed
the
1449_subjects_edit_success
branch
from
62f02d4 to
1084c89
Compare
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the first part of this data clean up we created a new column
deconcatenated_subjectand copied all subjects here, cleaning up the ones we've identified.Now we want to replace the subjects column with these values.
#1449 #1627
What's New
We remove the subject column and rename
deconcatenated_subjecttosubject. Also clean up the ERA_subjects_issue.txt file and reference in the previous migration.