Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beef up AR migrations with null:false #1705

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ and releases in Jupiter project adheres to [Semantic Versioning](http://semver.o
- Move Logic from SearchController into ItemSearch Concern [#932](https://github.com/ualbertalib/jupiter/issues/932)
- Feature Image on Item show page need to be centered align within column [#1405](https://github.com/ualbertalib/jupiter/issues/1405)
- Centralize Abstraction for Thumbnail Generation [#1343](https://github.com/ualbertalib/jupiter/issues/1343)
- Beefed up AR migrations by stating that certain attributes cannot be null [PR#1704](https://github.com/ualbertalib/jupiter/pull/1704)

### Fixed
- failing tests [#1376](https://github.com/ualbertalib/jupiter/issues/1376)
Expand Down
2 changes: 1 addition & 1 deletion db/migrate/20190806193807_add_ar_community.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def change
t.datetime :record_created_at
t.string :hydra_noid
t.datetime :date_ingested
t.string :title
t.string :title, null: false
t.string :fedora3_uuid
t.string :depositor
t.text :description
Expand Down
2 changes: 1 addition & 1 deletion db/migrate/20190806193857_add_ar_collection.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def change
t.datetime :record_created_at
t.string :hydra_noid
t.datetime :date_ingested
t.string :title
t.string :title, null: false
t.string :fedora3_uuid
t.string :depositor
t.uuid :community_id
Expand Down
6 changes: 3 additions & 3 deletions db/migrate/20190815215625_create_ar_item.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ def change
t.references :owner, null: false, index: true, foreign_key: {to_table: :users, column: :id}
t.datetime :record_created_at
t.string :hydra_noid
t.datetime :date_ingested
t.string :title
t.datetime :date_ingested, null: false
t.string :title, null: false
t.string :fedora3_uuid
t.string :depositor
t.string :alternative_title
Expand All @@ -21,7 +21,7 @@ def change
t.integer :sort_year
t.json :embargo_history, array: true
t.json :is_version_of, array: true
t.json :member_of_paths, array: true
t.json :member_of_paths, null: false, array: true
t.json :subject, array: true
t.json :creators, array: true
t.json :contributors, array: true
Expand Down
6 changes: 3 additions & 3 deletions db/migrate/20190822183423_create_ar_thesis.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ def change
t.references :owner, null: false, index: true, foreign_key: {to_table: :users, column: :id}
t.datetime :record_created_at
t.string :hydra_noid
t.datetime :date_ingested
t.string :title
t.datetime :date_ingested, null: false
t.string :title, null: false
t.string :fedora3_uuid
t.string :depositor
t.string :alternative_title
Expand All @@ -22,7 +22,7 @@ def change
t.json :embargo_history, array: true
t.json :is_version_of, array: true

t.json :member_of_paths, array: true
t.json :member_of_paths, null: false, array: true
t.json :subject, array: true

t.text :abstract
Expand Down