add tmp/cache to docker ignore #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid `Errno::EACCES: Permission denied @ rb_sysopen - /app/tmp/cache/bootsnap-load-path-cache.1.18857.tmp` error don't copy in that cache!
pgwillia
requested review from
ConnorSheremeta,
lagoan,
mbarnett and
murny
as code owners
murny
reviewed
Jul 30, 2020
| @@ -3,6 +3,7 @@ | |||
| *.md | |||
|
|
|||
| tmp | |||
There was a problem hiding this comment.
Shouldn't tmp here cover everything in tmp directory? including cache? 🤔
(of course except for us excluding tmp/pids/.keep below)
There was a problem hiding this comment.
I'll try building this branch from docker hub to see if it has the same results I'm seeing locally. But I didn't have to remove volumes and everything else as before after using the image I built with just this change.
There was a problem hiding this comment.
Confirmed the docker hub image has the same result.
|
@murny we were talking about adding a user/group but it turns out that the problem was in the .dockerignore after all. The documentation suggests that the |
murny
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
to avoid
Errno::EACCES: Permission denied @ rb_sysopen - /app/tmp/cache/bootsnap-load-path-cache.1.18857.tmperror don't copy in that cache!Related to #1680
What's New
Ignore tmp/cache directory when building docker images.