Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Skylight on Staging #1865

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Conversation

mbarnett
Copy link
Contributor

@mbarnett mbarnett commented Sep 9, 2020

Context

We definitely have some asset-related performance issues on Staging, and need to do some profiling to see what's up.

What's New

Enable Skylight in the staging Rails environment. Also removes "UAT" as an enabled environment, since we were never actually giving it the skylight tokens on UAT, and the performance measures are less likely to be representative.

murny
murny previously approved these changes Sep 9, 2020
Copy link
Contributor

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mbarnett
Copy link
Contributor Author

mbarnett commented Sep 9, 2020

Shouting Rubocop! at the sky and shaking my fist

Copy link
Contributor

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gif

@mbarnett mbarnett merged commit ba993da into integration_postmigration Sep 9, 2020
@mbarnett mbarnett deleted the add_skylight_staging branch September 9, 2020 22:32
@pgwillia pgwillia mentioned this pull request Dec 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants