Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.8.1 to 2.9.0 #2019

Merged
merged 4 commits into from
Dec 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ and releases in Jupiter project adheres to [Semantic Versioning](http://semver.o
- Fixed flapping announcement tests [#1915](https://github.com/ualbertalib/jupiter/issues/1915)
- Fixed not being able to clear a community logo [#2009](https://github.com/ualbertalib/jupiter/issues/2009)
- Fixed getting an error when deleting an item [#2009](https://github.com/ualbertalib/jupiter/issues/2009)
- bump rubocop and fix cop violations [PR#2019](https://github.com/ualbertalib/jupiter/pull/2019)

### Security
- add `noopener noreferrer` when opening a link in a new tab [PR#1344](https://github.com/ualbertalib/jupiter/pull/1344)
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -380,10 +380,10 @@ GEM
rubocop-performance (1.9.1)
rubocop (>= 0.90.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rails (2.8.1)
rubocop-rails (2.9.0)
activesupport (>= 4.2.0)
rack (>= 1.1)
rubocop (>= 0.87.0)
rubocop (>= 0.90.0, < 2.0)
ruby-progressbar (1.10.1)
ruby-saml (1.11.0)
nokogiri (>= 1.5.10)
Expand Down
2 changes: 1 addition & 1 deletion app/models/concerns/draft_properties.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module DraftProperties
validates :files, presence: true, if: :validate_upload_files?
validate :files_are_virus_free, if: :validate_upload_files?

scope :unpublished, -> { where(status: :active).where('uuid IS NULL') }
scope :unpublished, -> { where(status: :active).where(uuid: nil) }

def communities
return unless member_of_paths.present? && member_of_paths['community_id']
Expand Down