Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send failures to SessionController in development environment #2121

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Don't send failures to SessionController in development environment #2121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e33572
Don't send failures to SessionController in development environment
pgwillia Jan 26, 2021
41a50e8
Update CHANGELOG.md
pgwillia Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and releases in Jupiter project adheres to [Semantic Versioning](http://semver.o
– Turn off reporting things like "this excel spreadsheet isn't thumbnailable" as warnings to Rollbar [PR#2046](https://github.com/ualbertalib/jupiter/pull/2046)
- migration to fix concatenated subjects (part 2) [#1449](https://github.com/ualbertalib/jupiter/issues/1449)
- Catch and log embargo expiry job save errors [#1989](https://github.com/ualbertalib/jupiter/issues/1989)
- Don't send failures to SessionController in development environment [PR#2121](https://github.com/ualbertalib/jupiter/pull/2121)

### Fixed
- bump rubocop and fix cop violations [PR#2072](https://github.com/ualbertalib/jupiter/pull/2072)
Expand Down
2 changes: 1 addition & 1 deletion config/initializers/omniauth.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# By default in development mode, omniauth raises an exception when authentication fails
# comment this line if you want to see the stacktrace from the actual provider when in `development`
# Uncomment the line below to turn this behavior off
on_failure { |env| SessionsController.action(:failure).call(env) }
on_failure { |env| SessionsController.action(:failure).call(env) } unless Rails.env.development?

OmniAuth.config.allowed_request_methods = [:post]
OmniAuth.config.logger = Rails.logger
Expand Down