Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic skylight setup #310

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Basic skylight setup #310

merged 2 commits into from
Dec 8, 2017

Conversation

mbarnett
Copy link
Contributor

@mbarnett mbarnett commented Dec 7, 2017

Closes #299. We'll need to set the environment variable to the correct token on UAT.

@mbarnett mbarnett requested a review from weiweishi December 7, 2017 23:05
weiweishi
weiweishi approved these changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@weiweishi weiweishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mbarnett mbarnett merged commit 720a152 into ualbertalib:master Dec 8, 2017
@pgwillia pgwillia mentioned this pull request Dec 20, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiweishi weiweishi weiweishi approved these changes

@murny murny murny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbarnett @murny @weiweishi