Cut 2.9.1 release and update changelog #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorSheremeta
requested review from
jefferya,
lagoan,
murny and
pgwillia
as code owners
lagoan
previously approved these changes
May 16, 2024
CHANGELOG.md
Outdated
| ### Fixed | ||
| * Improves performance of Active Storage lookups via adding an table index. | ||
| Requires a db:migration that creates the index concurrently thus does not | ||
| lock the DB table [PR#3428](https://github.com/ualbertalib/jupiter/pull/3428) | ||
| * Fixed edge case on batch ingest front end tool where metadata is invalid [#3148](https://github.com/ualbertalib/jupiter/issues/3148) | ||
| * #3429: Fix unsafe redirect errors by using allow_other_host [PR#3429](https://github.com/ualbertalib/jupiter/pull/3429) |
There was a problem hiding this comment.
I only saw 2 entries in the changelog where we specify the ticket at the beginning of the sentance. Would it make sense to add it to the end, as it has been done with the rest?
Sorry if I missed something.
There was a problem hiding this comment.
I have removed those two leading ticket numbers in the changelog. I think they might have been auto generated at some point, it would be good to stay consistent however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update changelog with dependabot PRs and bump jupiter version to cut a release