Fix member id extraction and work with bookmarks #17

isbear · 2017-08-03T21:29:35Z

Fixes for:

circular reference warning (parameter member_id has the same name as accessor member_id)
fix already logged in session member_id detection
ignore 'my pixiv only' works in lists
some more fixes to bookmark list parsing

> lib/pixiv/client.rb:57: warning: circular argument reference - member_id

If you have saved your cookie, on the next script run you'll get already logged-in page, so, you need to populate @member_id.

Now it uses double-quotes instead of single-quotes

Use data-src attribute instead of src, since src without JS points to trasparent.gif

isbear · 2017-08-03T21:34:28Z

P.S. Sorry, I am not yet familiar enough with rspec to fix the tests as well.

Original image may have jpg or png extensions, while resized images always have jpg extension, so we cannot use medium_image_url as a reference to create original image url.

Code was not updated to work with new image_url_components and produced garbage. Not sure, how the situation with file extensions, but at least the url components are valid.

I am not interested currently in investigating this form of media any further, so, I just added indicatior to skip these...

isbear

File extensions for manga are an issue. Will try to figure something out during the week.

isbear added 6 commits August 3, 2017 22:21

Fix circular reference warning

1dcdc5e

> lib/pixiv/client.rb:57: warning: circular argument reference - member_id

Fix member id detection, on persistent session

9e968ca

If you have saved your cookie, on the next script run you'll get already logged-in page, so, you need to populate @member_id.

Fix owned illustrations list member id detection

056c469

Now it uses double-quotes instead of single-quotes

Fix bookmark list image detection

ca6fcca

Fix private work/bookmark handling

3438209

Use data-src attribute instead of src, since src without JS points to trasparent.gif

Skip 'my pixiv only' bookmarks/works

57b6e18

isbear added 3 commits August 4, 2017 02:02

Fix original image url

0687c97

Original image may have jpg or png extensions, while resized images always have jpg extension, so we cannot use medium_image_url as a reference to create original image url.

Fix manga original image urls

2b8516f

Code was not updated to work with new image_url_components and produced garbage. Not sure, how the situation with file extensions, but at least the url components are valid.

Add Illust#gif? method to detect animated images

a811f0b

I am not interested currently in investigating this form of media any further, so, I just added indicatior to skip these...

isbear commented Aug 12, 2017

View reviewed changes

Fix bookmark_list member url

68c35e0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix member id extraction and work with bookmarks #17

Fix member id extraction and work with bookmarks #17

isbear commented Aug 3, 2017

isbear commented Aug 3, 2017

isbear left a comment •

edited

Loading

Fix member id extraction and work with bookmarks #17

Are you sure you want to change the base?

Fix member id extraction and work with bookmarks #17

Conversation

isbear commented Aug 3, 2017

isbear commented Aug 3, 2017

isbear left a comment • edited Loading

Choose a reason for hiding this comment

isbear left a comment •

edited

Loading