Feature/config watch table #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
4fdal
commented
May 19, 2021
•
4fdal
commented
added 2 commits
May 19, 2021 13:47
1. add new config badaso-hidden-tablles 2. add new config badaso-watch-tables 3. automatic add table in config watch
1. add new config badaso-hidden-tablles
2. add new config badaso-watch-tables
3. automatic add table in config watch
4. client verify license if error code 500
other file change :
modified: src/Badaso.php
renamed: src/Config/hidden-tables.php -> src/Config/badaso-hidden-tables.php
new file: src/Config/badaso-watch-tables.php
modified: src/Config/badaso.php
modified: src/Controllers/BadasoBaseController.php
modified: src/Controllers/BadasoCRUDController.php
new file: src/Helpers/HiddenWatchTableConfig.php
modified: src/Providers/BadasoServiceProvider.php
Apply fixes from StyleCI
…t-indonesia/badaso into feature/config_watch_table
rizkiheryandi
requested changes
May 20, 2021
| @@ -0,0 +1,95 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Should be separate file for watch and hidden helper
|
Didn't found changes for "4. client verify license if error code 500" |
1. add helper class hidden table 2. add helper class watch table
…into feature/config_watch_table
Apply fixes from StyleCI
rizkiheryandi
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.