Publish containers to docker.io #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be an issue with ghcr.io where published containers can't
be pulled ('manifest unknown' error), so moving to docker.io.
uatuko
force-pushed
the
feature/publish-docker-io
branch
2 times, most recently
from
22039ea
to
9c86b1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 21 21
Lines 1406 1406
Branches 168 168
=======================================
Hits 1320 1320
Misses 59 59
Partials 27 27 ☔ View full report in Codecov by Sentry. |
uatuko
force-pushed
the
feature/publish-docker-io
branch
from
9c86b1c
to
53450bf
Compare
uatuko
force-pushed
the
feature/publish-docker-io
branch
3 times, most recently
from
9f722f2
to
7fba022
Compare
Publish containers to both docker.io and ghcr.io since using g++ cross-compile seems to have resolved the "manifest unknown" issue for `docker` (`podman` v5.0.2 still has the issue).
uatuko
force-pushed
the
feature/publish-docker-io
branch
3 times, most recently
from
dae0419
to
c2c7a87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue with
ghcr.iowhere published containers can't be pulled ('manifest unknown' error), so moving todocker.io.Update: docker/build-push-action#820 (comment) suggested the issue could be due to cross-compiling/how multi-arch images are created. After updating the builds to use g++ cross-compile (instead of using QEMU to create multi-arch containers) it seems
dockercan pull ghcr.io images now.Notes
10th November, 2024
Inspecting the builds produced by https://github.com/uatuko/ruek/actions/runs/11767516276 seems to show both ghcr.io and docker.io having the same build manifests.
ghcr.io/uatuko/ruek
docker.io/uatuko/ruek
However, while docker.io images can be pulled ghcr.io images gives "manifest unknown" error.
Update - 1: It used to be both
podmananddockergave the same "manifest unknown" result. However, after inspecting images usingdockerand pulling from docker.io first, I can now pullghcr.io/uatuko/ruekimage as well (could be a coincident?)Update - 2: Well, it looks like after https://github.com/uatuko/ruek/actions/runs/11768032663 even
podmannow works. But the docker.io image was pulled before the ghcr.io image.