Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download problem redirect #236

Closed
5 tasks done
Tas6s opened this issue Aug 27, 2023 · 5 comments
Closed
5 tasks done

Download problem redirect #236

Tas6s opened this issue Aug 27, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Tas6s
Copy link

Tas6s commented Aug 27, 2023

Preliminary checklist

  • I have read the README.
  • I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
  • I have read the FAQs.
  • I have updated Cromite to the latest version. The bug is reproducible on this latest version.
  • This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

Yes

Cromite version

Latest

Device architecture

arm

Android version

13

Device model

Samsung tab s8 plus

Changed flags

No

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

I have one problem i can't download from web site like liteapk.com when it redirect me to cloudservice chromite loading the first page instead of start download the file please help

Steps to reproduce the bug

Go to www.liteapk.com and try download any apk

Expected behavior

Return to home page of the web page

Screenshots

No response

@catgangdev
Copy link

Yes have same issue. Alternatively you can long press on that Download link and select download link option from pop up menu. Download will start.
I don't know might be site issue.

@Tas6s
Copy link
Author

Tas6s commented Aug 28, 2023

Yes have same issue. Alternatively you can long press on that Download link and select download link option from pop up menu. Download will start. I don't know might be site issue.

Yes this works thank you!

@uazo
Copy link
Owner

uazo commented Aug 28, 2023

duplicate of #149

@uazo
Copy link
Owner

uazo commented Aug 28, 2023

Alternatively you can long press on that Download link and select download link option from pop up menu. Download will start.

this is a bug.
Although I like it as a workaround, it must at least warn the user.

@uazo uazo added the need triage I will look into it, I promise! label Aug 28, 2023
@uazo uazo mentioned this issue Oct 30, 2023
@uazo uazo added bug Something isn't working and removed need triage I will look into it, I promise! labels Nov 1, 2023
@uazo
Copy link
Owner

uazo commented Dec 22, 2023

Although I like it as a workaround, it must at least warn the user.

Unfortunately, it is too invasive to implement and not worth the effort.
What I am doing is

  • relax verification using etld+1 and not the origin
  • add verification also in downloads in android, in windows the code is different and already provides for it

uazo added a commit that referenced this issue Dec 22, 2023
added check also in download via context menu in android
@uazo uazo added the working on it working on it label Dec 24, 2023
@uazo uazo closed this as completed Jan 5, 2024
@uazo uazo removed the working on it working on it label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants