translation with Deepl

[LeOS-GSI]

Preliminary checklist

• I have read the README
• I have read the FAQs.
• I have searched existing issues for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue.
• This is a feature request for the Bromite browser; not the website nor F-Droid nor anything else.

Is your feature request related to privacy?

Yes

Is there a patch available for this feature somewhere?

Yes, in Brave

Describe the solution you would like

You have complete disabled translation, because it's using googel translate. Brave is using Deepl for translation. Would be great if you could implement it too.

Describe alternatives you have considered

none

[xd003]

+1 Agreed with this
Would be good to have some sort of translation service added. (Deepl or other service better than it )

[uazo]

Brave is using Deepl for translation.

would you be able to extract the code they made?
not necessarily to copy it, but to understand how it works.

[LeOS-GSI]

I don't know if this will help. This a script which should enable translations. https://greasyfork.org/en/scripts/457196-immersive-translate
or this patch from Brave
https://github.com/brave/brave-core/blob/master/patches/chrome-browser-ui-views-translate-translate_bubble_view_unittest.cc.patch

but I think there is more to do as using that patch

[Universalizer]

https://github.com/search?q=repo%3Abrave%2Fbrave-core%20translate&type=code

https://github.com/search?q=repo%3Abrave%2Fbrave-core+translate&type=pullrequests

https://github.com/search?q=repo%3Abrave%2Fbrave-core+translate&type=commits

[LeOS-GSI]

By the way, I have learned, that it's easy possible to translate text in browser.

• Install a translation app like Deepl or TranslateYou
• select the text you want translate
• and in the toast you will see 'translate' (on small devices you have to push the hamburger menu in the toast)

Details

translate.mp4

[uazo]

I checked and it will not be possible to integrate the translation feature into this browser because it needs external servers to work.
furthermore, the code only provides for the implementation that works with google translator, which involves a request to their api to receive a minimized (thus unverifiable) javascript to inject into the page, then it does everything with the help of internal code that allows it to modify the html of the page.

the solution of an external app is a good solution, but the app must be open source. and you should also look at the privacy policies (e.g. deepl pro (paid) look better than that of free version)

[uazo]

I'm curious to see how this works:

[LeOS-GSI]

I like that solution. :))

[LeOS-GSI]

by the way, it's also working with TranslateYou app

video_2023-07-29_13-40-48.mp4

[dhananjaipai]

One workaround I found with the translation issue is to also have Google Chrome installed and use the "Share" option from Cromite to open the URL in Chrome and get the translation thereof.
Not really a fix, but if you want to use Google Translate for certain pages without compromising on the other features like adblock and integrated privacy, this may be a best of both worlds with Cromite and Chrome.

[AntarCrypto]

I don't know if this will help. This a script which should enable translations. https://greasyfork.org/en/scripts/457196-immersive-translate or this patch from Brave https://github.com/brave/brave-core/blob/master/patches/chrome-browser-ui-views-translate-translate_bubble_view_unittest.cc.patch

but I think there is more to do as using that patch

how can I install the github script

[drogga]

It sux being limited in the name of privacy or whatever and not being able to translate whole pages at once, instead of a selected text one by one and having use another browser just for this, for example Kiwi and thankfully it supports extensions, unlike this one and many others, because imagine having to defeat the whole purpose of this browser by using say stock Chrome on riddled with ads and whatnot sites, just to translate a page, Kiwi even supports translate continuation (probably no exclusive to it) from one topic page to the another, which is super convenient.
Oh and I installed the "Immersive Translate" script from greasyfork and toggled both switches on, but unfortunately there's no way to trigger/call/activate it on a page (or I don't see any)... > Edit: Explained in issue ticket 589 that it sux in this too.

[xd003]

Agreed with you @drogga
I support the "privacy - open-source bandwagon" only till it doesn't affect the browsing experience in such major way. Translation is one of the very important aspect of core browsing experience. It isn't even a feature per se. Practicality/Convenience > Privacy until open source really provides a solid alternative for everything

[uazo]

It sux being limited in the name of privacy or whatever and not being able to translate whole pages at once,
I support the "privacy - open-source bandwagon" only till it doesn't affect the browsing experience in such major way.

I am sorry, but my position is different, for me privacy takes priority over needs.
in any case, if I manage to activate a proxy for the google api (and I'm thinking about it), which can be used by all cromite users, I think this functionality could be activated, but for me it is low priority.
there are too many more urgent things to do.
However, I have no intention of giving up cromite, so who knows, maybe in the future.

[xd003]

Just wanted to ask if translation is broken in the windows version as well

[uazo]

if translation is broken in the windows version as well

yes, the translation with google API is deactivated (not broken :)

[NgnVhung]

Is there a way to add language translation functionality?
You can release another parallel update and add language translation functionality ???
I hope so much 😍😍

[uazo]

Is there a way to add language translation functionality?

so far I have not found any way.

You can release another parallel update and add language translation functionality ???

no, sorry.