Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JXL support in linux builds #665

Closed
wants to merge 1 commit into from
Closed

Enable JXL support in linux builds #665

wants to merge 1 commit into from

Conversation

emkw
Copy link

@emkw emkw commented Jan 6, 2024

Description

I propose to add JXL support for linux builds; the recently released linux build doesn't support it.
Unfortunately I don't know how to make a test build, so I'm not sure if it builds correctly.

All submissions

  • there are no other open Pull Requests for the same update/change
  • Bromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

@PF4Public
Copy link

Adding enable_jxl_decoder=true to gn args could do it without changing the patch.

@uazo
Copy link
Owner

uazo commented Jan 6, 2024

Unfortunately I don't know how to make a test build, so I'm not sure if it builds correctly.

I'd like you to try, I can help you it's simple, will you?

@PF4Public
Copy link

it's simple

But it's computationally intensive :)

enable_jxl_decoder=true Cromite left, ungoogled-chromium without jxl support right:
Unbenannt

@uazo
Copy link
Owner

uazo commented Jan 6, 2024

But it's computationally intensive :)

mah, I think a good machine today is capable, and I think it is capable even while using the PC for something else, just adjust the number of threads to suit your needs.
it is only a matter of time, and space, that yes, but who doesn't have 100gb available :)
anyone can try the cromite build with three simple steps (and I would like to know the times according to the configurations :)

@emkw
Copy link
Author

emkw commented Jan 6, 2024

But it's computationally intensive :)

That might pose a problem as I'm on low spec CPU

@PF4Public
Copy link

PF4Public commented Jan 6, 2024

I would like to know the times according to the configurations

It takes almost 16 hours on E3-1246 v3 @ 3.50GHz

I think it is capable even while using the PC for something else, just adjust the number of threads to suit your needs.

Correct, on Linux one could adjust process "niceness" to lower its priority for computer resources.

uazo added a commit that referenced this pull request Jan 7, 2024
@uazo
Copy link
Owner

uazo commented Jan 7, 2024

I preferred this one #665 (comment), added directly in cromite.gn_args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants