Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See previous years' member stats #476

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

stevenh17
Copy link
Contributor

@stevenh17 stevenh17 commented Oct 13, 2023

🎟️ Ticket(s): Closes #

πŸ‘· Changes: A brief summary of what changes were introduced.
Added a button to choose and view member stats by year.

In the first photo, we can see the default setting is 2024 and it shows 12 data points.
In the second photo, when the button is clicked, it opens up the list of years to choose from.
In the third photo, we've selected 2021 and it shows 519 data points.

The fourth photo shows a mobile view.

πŸ’­ Notes: Any additional things to take into consideration.
How thoroughly am I supposed to test this? I'm not sure if I've covered all bases.

Wait! Before you merge, have you checked the following:

πŸ“· Screenshots
Screenshot 2023-11-20 at 7 13 02 PM
Screenshot 2023-11-20 at 7 13 20 PM
Screenshot 2023-11-20 at 7 20 33 PM

(prefer animated gif)

Checklist

  • Looks good on large screens
  • Looks good on mobile
image

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 1b9a3ce):

https://bt-web-dev-ebf17--pr476-seepreviousmembersta-2s05ebj7.web.app

(expires Fri, 20 Oct 2023 02:59:02 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: a1bf7afe94c954469059b9e3898cf94f4178c379

Copy link
Member

@ddennis924 ddennis924 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we need to add new years? how is that handled

<MenuItem value="2024">2024</MenuItem>
</Select>
</FormControl>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console log remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants