Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy releases (tags) to prod #64

Merged
merged 2 commits into from
May 7, 2020
Merged

Deploy releases (tags) to prod #64

merged 2 commits into from
May 7, 2020

Conversation

ianmah
Copy link
Member

@ianmah ianmah commented May 6, 2020

Instead of deploying by merging to branch prod, deploy by making a new release. What is a release

Also created pull request template (When creating a PR, the template will be used)

Docs used:
https://docs.travis-ci.com/user/conditions-v1
https://help.github.com/en/github/administering-a-repository/about-releases
https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository

ianmah added 2 commits May 6, 2020 14:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@jacqueschen1 jacqueschen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis seems to be passing despite a failing test..?

Copy link
Member

@jacqueschen1 jacqueschen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm that has nothing to do with this PR

@ianmah ianmah merged commit e67c623 into master May 7, 2020
@ianmah ianmah deleted the travis-deploy-releases branch May 7, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants