Skip to content

Commit

Permalink
Add enabling flag for examapi, move pv/pvc out of deployment
Browse files Browse the repository at this point in the history
  • Loading branch information
xcompass committed Feb 21, 2024
1 parent 6c41185 commit ffdb180
Show file tree
Hide file tree
Showing 7 changed files with 48 additions and 43 deletions.
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1 +1 @@
jupyterhub/templates/**
jupyterhub/templates/
40 changes: 1 addition & 39 deletions jupyterhub/templates/examapi/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.examapi.enabled -}}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down Expand Up @@ -80,43 +81,4 @@ spec:
- name: jupyterhub-efs
persistentVolumeClaim:
claimName: {{ include "jupyterhub.examapi.fullname" . }}
---

apiVersion: v1
kind: PersistentVolume
metadata:
name: {{ include "jupyterhub.examapi.fullname" . }}
spec:
capacity:
storage: 5Gi
volumeMode: Filesystem
accessModes:
- ReadWriteMany
persistentVolumeReclaimPolicy: Retain
storageClassName: {{ .Values.examapi.storageClassName }}
csi:
driver: efs.csi.aws.com
volumeHandle: {{ .Values.examapi.efsHandle }}

---

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: {{ include "jupyterhub.examapi.fullname" . }}
spec:
accessModes:
- ReadWriteMany
storageClassName: {{ .Values.examapi.storageClassName }}
resources:
requests:
storage: 5Gi

{{- if .Values.examapi.createStorageClass }}
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: {{ .Values.examapi.storageClassName }}
provisioner: efs.csi.aws.com
{{- end }}
2 changes: 2 additions & 0 deletions jupyterhub/templates/examapi/ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.examapi.enabled -}}
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
Expand Down Expand Up @@ -25,3 +26,4 @@ spec:
name: {{ include "jupyterhub.examapi.fullname" . }}
port:
number: 5000
{{- end }}
39 changes: 39 additions & 0 deletions jupyterhub/templates/examapi/pv.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
apiVersion: v1
kind: PersistentVolume
metadata:
name: {{ include "jupyterhub.examapi.fullname" . }}
spec:
capacity:
storage: 5Gi
volumeMode: Filesystem
accessModes:
- ReadWriteMany
persistentVolumeReclaimPolicy: Retain
storageClassName: {{ .Values.examapi.storageClassName }}
csi:
driver: efs.csi.aws.com
volumeHandle: {{ .Values.examapi.efsHandle }}

---

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: {{ include "jupyterhub.examapi.fullname" . }}
spec:
accessModes:
- ReadWriteMany
storageClassName: {{ .Values.examapi.storageClassName }}
resources:
requests:
storage: 5Gi

{{- if .Values.examapi.createStorageClass }}
---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
name: {{ .Values.examapi.storageClassName }}
provisioner: efs.csi.aws.com
{{- end }}
5 changes: 2 additions & 3 deletions jupyterhub/templates/examapi/secrets.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.examapi.enabled -}}
apiVersion: v1
kind: Secret
metadata:
Expand All @@ -7,6 +8,4 @@ metadata:
type: Opaque
data:
exam-api-key: {{ .Values.examapi.apiKey | b64enc | quote }}



{{- end }}
2 changes: 2 additions & 0 deletions jupyterhub/templates/examapi/service.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.examapi.enabled -}}
apiVersion: v1
kind: Service
metadata:
Expand Down Expand Up @@ -31,3 +32,4 @@ spec:
{{- with .Values.examapi.service.ports.nodePort }}
nodePort: {{ . }}
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions jupyterhub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@ cull:
maxAge: 0 # --max-age

examapi:
enabled: true
image:
name: lthub/jupyterhub-api
tag: sha-bc8937e
Expand Down

0 comments on commit ffdb180

Please sign in to comment.