Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects: admin messages not displayed, no easy way to add them in UI #194

Closed
dsajdak opened this issue Dec 16, 2019 · 4 comments · Fixed by #403
Closed

Projects: admin messages not displayed, no easy way to add them in UI #194

dsajdak opened this issue Dec 16, 2019 · 4 comments · Fixed by #403
Assignees

Comments

@dsajdak
Copy link
Contributor

dsajdak commented Dec 16, 2019

When updating an allocation, admins should be able to add a new message to the users. There is no way to do this in the UI, only in the Django backend. Even after adding an admin message on an allocation in the backend, it is not displaying in the allocation details in the UI.

@zooley
Copy link
Contributor

zooley commented Jan 13, 2020

When "... adding an admin message on an allocation in the backend ...", did you add this under "Allocation admin notes" or "Allocation user notes"? When testing, I noticed messages added under "Allocation user notes" are what seem to to show up on the front-end under "Messages from System Administrators" when looking at an allocation's details. Messages added under "Allocation admin notes", do not appear on the front-end (from what I could see).

This may be a case of poor/confusing wording. Hopefully someone can correct me if I'm wrong, but I think "Allocation user notes" is meant as "Admin notes to the user" and "Allocation admin notes" is meant as "Admin notes to other admins".

In any case, I agree that a button on the front-end for adding a message directly from the allocations details page would make sense.

@dsajdak dsajdak changed the title admin messages not display, no easy way to add them in UI admin messages not displayed, no easy way to add them in UI Apr 2, 2020
@dsajdak dsajdak changed the title admin messages not displayed, no easy way to add them in UI Projects: admin messages not displayed, no easy way to add them in UI Nov 17, 2020
@dsajdak
Copy link
Contributor Author

dsajdak commented Jan 13, 2021

Verify that emails are sent to PIs when these messages are added.

@Iain-S
Copy link
Contributor

Iain-S commented Jul 12, 2021

I agree with @zooley that the wording is confusing and it isn't clear whether the user notes are meant to be left by or for the users.

I think it would be great for both normal users / PIs and admins to be able to leave notes for each other via the Allocation Detail page.

@dsajdak
Copy link
Contributor Author

dsajdak commented Jan 14, 2022

Button to add notes on allocations and allocation change requests has been exposed via these PRs: #330
#346

Still to do is adding the button on the Project detail page and deciding if we want to allow users and managers to be able to add these.

@dsajdak dsajdak moved this to Ready for Review in ColdFront Jun 8, 2022
@dsajdak dsajdak added this to ColdFront Jun 8, 2022
@dsajdak dsajdak moved this from Ready for Review to In Progress in ColdFront Jun 8, 2022
@dsajdak dsajdak moved this from In Progress to Ready for Review in ColdFront Jun 8, 2022
@dsajdak dsajdak moved this from Ready for Review to In Progress in ColdFront Jun 8, 2022
aebruno added a commit that referenced this issue Jun 17, 2022
…t-detail-page

Add 'notes' button on project detail page
Repository owner moved this from In Progress to Completed in ColdFront Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants