Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Allocation Change Request features to Allocation Requests #341

Closed
dsajdak opened this issue Dec 21, 2021 · 2 comments
Closed

Port Allocation Change Request features to Allocation Requests #341

dsajdak opened this issue Dec 21, 2021 · 2 comments

Comments

@dsajdak
Copy link
Contributor

dsajdak commented Dec 21, 2021

With the allocation change request feature we modified some of the process flow. This process should be ported back to the allocation requests for a more seamless process across the two. What to update on allocation requests:

Allocation detail page:

  • Expose button to add 'notifications' so admin can include details about allocation request
  • Allow 'lock/unlock' to be set here like the 'allow change requests'

Allocation request list:

  • Change 'Date Requested/Last Modified' to 'Last Modified'
  • Change 'Allocation Actions' to 'Actions'
  • Add 'Details' button to get to Allocation detail page
  • Unlink ID number as this will now be the 'Details' button
  • Grey out 'Activate' if allocation is new - this is because allocation attributes need to be added to new allocations before allocation is approved
  • Remove 'Deny' button and require admin to use 'Details' to specify a reason for denying an allocation
@dsajdak
Copy link
Contributor Author

dsajdak commented Dec 28, 2021

After discussion, we decided:

  • Activate button on 'Allocation Requests' list will be greyed out for new allocations, forcing admin to view the allocation details
  • We will not require allocation attributes but admin will get a pop-up asking if they're sure they want to activate an allocation with no attributes
  • Also will not require a reason for a denial but admin will get a pop-up asking if they want to provide a reason

brisco17 added a commit to brisco17/coldfront that referenced this issue Dec 29, 2021
brisco17 added a commit to brisco17/coldfront that referenced this issue Jan 7, 2022
brisco17 added a commit to brisco17/coldfront that referenced this issue Jan 7, 2022
… by default. Will only happen if allocation is approved/has its status changed to approve. Dates will now be cleared if status is changed to 'New' or 'Denied'
aebruno added a commit that referenced this issue Jan 11, 2022
…flow

Ported Allocation Change Request features to Allocation Requests
@aebruno
Copy link
Member

aebruno commented Jan 11, 2022

Closed in #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants