Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Django 3.2 #353

Merged
merged 9 commits into from
Feb 7, 2022
Merged

Upgrade to Django 3.2 #353

merged 9 commits into from
Feb 7, 2022

Conversation

aebruno
Copy link
Member

@aebruno aebruno commented Jan 13, 2022 •
edited
Loading

This closes #295. Upgrade to Django 3.2 along with upgraded all deps.

Notes:

  • Django Q requires setting retry/timeout
  • staticfiles template tag is deprecated. Any custom templates will need to be updated
  • Upgrading will require running coldfront migrate
  • For MariaDB users, STRICT_TRANS_TABLES can be enabled by adjusting the DB_URL config value like so:
DB_URL=mysql://USER:PASS@HOST:3306/coldfront?init_command=SET+sql_mode%3D%27STRICT_TRANS_TABLES%27

mdzik and others added 7 commits August 27, 2021 16:32
@mdzik
Bump all versions in requirements.txt
4ec9140
@mdzik
psycog2 model in django in deprecated
9792e85
@mdzik
Add
8e3078e 
name = 'allocation'
name = 'coldfront.core.allocation'

it rises error otherwise
@aebruno
Merge branch 'django-3.2-upstream' of https://github.com/mdzik/coldfront
9dfc44a 
 into upgrade-django-3-2

Conflicts:
	requirements.txt
@aebruno
Bump Django to 3.2.11 and upgrade all packages
356637b
@aebruno
staticfiles removed in Django 3.2
e04ec9e
@aebruno
Core config changes for Django 3.2.
ebf35a7 
- Set DEFAULT_AUTO_FIELD to maintain the historical behavior and avoid unwanted
migrations. In future Django release the default value will be changed to BigAutoField.

- Set AppConfig.default to False to prevent Django from auto selecting app configuration

- Django Q now requires setting retry/timeout values. It's important that the
timeout value be less that the retry value.
@aebruno aebruno marked this pull request as ready for review January 13, 2022 17:16
@aebruno aebruno requested a review from dsajdak January 13, 2022 17:16
@aebruno
Re-enable automatic app discovery.
8da8648 
- Ensure plugins use dotted path for app config
dsajdak
dsajdak approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@dsajdak dsajdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aebruno aebruno merged commit d099d6a into master Feb 7, 2022
@aebruno aebruno deleted the upgrade-django-3-2 branch January 29, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsajdak dsajdak dsajdak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Django 3.2 LTS
3 participants
@aebruno @dsajdak @mdzik