Bootstrap updated #410
Closed
Bootstrap updated #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upgrading to d3 v7 breaks the charts. Upgrading c3 and d3 will be a bit more involved. We'll want to take a look at the various migration guides here: https://observablehq.com/@d3/d3v6-migration-guide and upgrade our code accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #405 — Bootstrap is now updated from version 4.3.1 to version 4.6.1, Popper is updated from version 1.14.7 to version 1.16.1, and JQuery is now updated from version 3.3.1 to version 3.6.0. Also updated C3 and D3 JS graph/ chart libraries to latest versions. Full UI was tested and no breaking changes were made.
Tested by logging in as a a user, manager (PI), staff, director, and admin and doing the following for each login (whatever was applicable for each user role):