Combined email expiry notifications with more information #413
Conversation
…llocation-email-expirations
… tied to each allocation, then perform final testing.
…ired. Finished implementation of sending emails for expired allocations
… current branch to be up to date.
…llocation-email-expirations
…, adjusted admin email template, and updated docs.
There was a problem hiding this comment.
Changes have been tested and look really good. Just a few other changes requested:
- When an allocation is set to expire today, we're not seeing that in any emails. It's not a separate email and the combined email is showing a breakdown of allocations expiring in 7, 14, and 30 days.
- For the admin email listing the allocations that have expired, let's remove the /renew in the URL. This is a remnant of the emails going to users and not necessary for the admins.
- For the admin email, no need to separate that list out by project as it doesn't matter to the admins. You can just list out all the allocations that expired that day.
…ute name change, performed final testing.
There was a problem hiding this comment.
Testing on this looks good. I think we just want to update this wording here and then we're good to go: https://github.com/ubccr/coldfront/pull/413/files/fa465b580b9a2ad6d30b06abe4b4730b2bb7d7de
coldfront/core/allocation/tasks.py
Outdated
| 'email/admin_allocation_expired.txt', | ||
| admin_template_context, | ||
| EMAIL_SENDER, | ||
| [EMAIL_TICKET_SYSTEM_ADDRESS,] |
There was a problem hiding this comment.
Let's send the admin email to the EMAIL_ADMIN_LIST instead of the ticket system address.
There was a problem hiding this comment.
Minor change requested on email subject & first line:
Email subject: Your access to resource(s) are expiring soon - change to 'Your access to [center name]'s resources is expiring soon'
First line: Your access to CCR resources are expiring soon. - change to 'Your access to [center name]' resources is expiring soon'
There was a problem hiding this comment.
Sorry meant for this to be a 'request changes' review. See comment: #413 (review)
Fixes #270 and Fixes #297 : Combined email expiry notifications for resources that are expiring soon. Also included more information given to the user for email notifications for resources expiring soon and expired resources.
Tested using task tests for #270 and included more statuses to test such as 'Payment Pending', 'Payment Requested', 'Unpaid' . Also tested different allocation attribute values for 'EXPIRE NOTIFICATION'.
Update: Fixes #289 : Edited original commit to send emails to center staff for allocations that have expired. This is configurable by setting 'ADMIN EXPIRE NOTIFICATION' allocation attribute to 'No' if receiving emails for a specific allocation is not desired. Need to run 'coldfront add_allocation_defualts' to update allocation choices.