Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arguments in signal definitions are obsolete #422

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Arguments in signal definitions are obsolete #422

merged 1 commit into from
Aug 5, 2022

Conversation

mdzik
Copy link
Contributor

@mdzik mdzik commented Jun 30, 2022

@dsajdak dsajdak added the needs review Waiting for review label Jul 21, 2022
@aebruno aebruno requested a review from dsajdak August 5, 2022 13:19
dsajdak
dsajdak approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@dsajdak dsajdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aebruno aebruno merged commit 6f13af1 into ubccr:master Aug 5, 2022
@dsajdak dsajdak removed the needs review Waiting for review label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsajdak dsajdak dsajdak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdzik @dsajdak @aebruno