Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker updated #443

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Datepicker updated #443

merged 2 commits into from
Aug 5, 2022

Conversation

rg663
Copy link
Collaborator

@rg663 rg663 commented Aug 1, 2022

Resolves #438 —

  • Datepicker changed to flatpickr
  • Flatpickr CSS and JS added as static files
  • JQuery UI plugin removed, since datepicker was the only previously used element
  • All instances of datepicker updated to flatpickr
  • Form control input background showing up correctly when flatpickr is added

Tested by checking all datepickers and confirming no breaking changes.

@rg663 rg663 changed the title flatpickr added, formatting for form control fixed Datepicker updated Aug 1, 2022
@dsajdak dsajdak added needs review Waiting for review and removed needs review Waiting for review labels Aug 2, 2022
@aebruno aebruno requested a review from dsajdak August 5, 2022 20:11
dsajdak
dsajdak approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@dsajdak dsajdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aebruno aebruno merged commit 5af1c12 into ubccr:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsajdak dsajdak dsajdak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ColdFront
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change datepicker widget
3 participants
@rg663 @dsajdak @aebruno